Skip to content

build: disallow ignoring blocking errors #9728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

build: disallow ignoring blocking errors #9728

merged 1 commit into from
Nov 17, 2020

Conversation

hauntsaninja
Copy link
Collaborator

Fixes #9727 (and effectively also adds a test for #9674)

build: disallow ignoring blocking errors
bf5a2aa 
Fixes python#9727 (and effectively also adds a test for python#9674)
JukkaL
JukkaL approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Looks good. This was potentially a pretty bad issue.

@JukkaL JukkaL merged commit fadb27f into python:master Nov 17, 2020
@hauntsaninja hauntsaninja deleted the block branch November 17, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error code misc and build errors
2 participants
@hauntsaninja @JukkaL