Skip to content

[mypyc] Cleanup old style primitive code #9699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2020
Merged

[mypyc] Cleanup old style primitive code #9699

merged 3 commits into from
Nov 4, 2020

Conversation

TH3CHARLie
Copy link
Collaborator

@TH3CHARLie TH3CHARLie commented Nov 4, 2020 •
edited
Loading

We have moved all the existing ops into the new IR, so this PR removes the old PrimitiveOp and related code

relates mypyc/mypyc#709, closes mypyc/mypyc#753

@TH3CHARLie TH3CHARLie changed the title remove old style primtive infra [mypyc] Cleanup old style primitive code Nov 4, 2020
@TH3CHARLie TH3CHARLie requested a review from JukkaL November 4, 2020 17:10
JukkaL
JukkaL approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, this is a big milestone! I love seeing so much legacy code deleted. The old primitives are now officially dead.

@JukkaL JukkaL merged commit 2695e95 into python:master Nov 4, 2020
@TH3CHARLie TH3CHARLie deleted the remove-old-primitive branch November 4, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remaining old style primitive ops
2 participants
@TH3CHARLie @JukkaL