Check __setattr__ when property is not settable #9196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuli
reviewed
Jul 29, 2020
JukkaL
reviewed
Jul 31, 2020
|
@JukkaL friendly ping |
hauntsaninja
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
This looks good to me, and it looks like Jukka's concerns have been addressed. Thanks @kamilturek for your series of PRs! :-)
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Sep 23, 2020
This reverts commit 3186281.
|
Actually, I think I'm going to revert this, see #9474 |
hauntsaninja
added a commit
that referenced
this pull request
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9160