Skip to content

Myunit #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Myunit #914

wants to merge 5 commits into from

Conversation

o11c
Copy link
Contributor

@o11c o11c commented Oct 12, 2015

Split myunit into separate modules. Preparation for #908.

Disable the lint warning about glob imports, there is nothing wrong with them if they are used carefully, and mypy itself will warn if you misuse them.

Also pass -q by default so it's less glitchy, to both myunit and unittest, though note that unittest will still produce some point.

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 12, 2015

I want to keep the public interface the same, i.e. import everything in __init__.py, and access everything externally via myunit instead myunit.main or similar -- like Python std lib unittest does it, for example. Having to remember several submodules an unnecessary complication, as myunit has a sufficiently small API.

@@ -0,0 +1,6 @@
"""Ick, mutable globals!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: Use the last """" on the same line as the first one for one-line docstrings, i.e. like this:

"""Ick, mutable globals!"""

@o11c
Copy link
Contributor Author

o11c commented Oct 12, 2015

myunit.main

Should that refer to the module or the function then?

@o11c
Copy link
Contributor Author

o11c commented Oct 13, 2015

Active members met and voted to ditch myunit entirely in favor of pytest. Closing.

(But fixing the python2 story comes first.)

@o11c o11c closed this Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants