Report note about binary operation on the same line as error #8936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we also suppress the note when ignoring the error.
mypy/checkexpr.py
Outdated
| @@ -2683,7 +2683,7 @@ def check_op(self, method: str, base_type: Type, | |||
| if len(left_variants) >= 2 and len(right_variants) >= 2: | |||
| self.msg.warn_both_operands_are_from_unions(context) | |||
| elif len(left_variants) >= 2: | |||
| self.msg.warn_operand_was_from_union("Left", base_type, context=right_expr) | |||
| self.msg.warn_operand_was_from_union("Left", base_type, context=context) | |||
| elif len(right_variants) >= 2: | |||
| self.msg.warn_operand_was_from_union("Right", right_type, context=right_expr) | |||
There was a problem hiding this comment.
Should we make the same change here?
There was a problem hiding this comment.
I updated the PR to do this more consistently.
|
@ilevkivskyi I updated the logic for finding the note location since a bunch of tests were failing. |
ilevkivskyi
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we also suppress the note when ignoring the error.