Skip to content

Resolves #8627 #8643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Resolves #8627 #8643

wants to merge 1 commit into from

Conversation

i64
Copy link

@i64 i64 commented Apr 6, 2020

No description provided.

@i64 i64 force-pushed the master branch 3 times, most recently from deaaccf to 58fb02c Compare April 6, 2020 20:13
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I think it doesn't solve the whole issue. This deals with it for types but also I think needs to deal with it for expressions in Python 3.

@i64
Copy link
Author

i64 commented Apr 10, 2020

Sorry, I don't understand what you mean with "expressions in Python 3"

@davidzwa
Copy link
Contributor

davidzwa commented Apr 10, 2020

Just a thought, I think he means Python 3.5, 3.6 etc (not only 3.9 and up), but I might be wrong as he mentions expressions (vs types).

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Apr 21, 2020

Hello!

I wrote up my own version of this fix, before I found that this PR existed. I believe Sully's referring to making sure anywhere else we visit_Subscript we do the right thing, which I think happens to work out (modulo some additional line and column setting).

You'll still want CI to pass though, feel free to look at my fix. Also happy to open a PR directly: https://github.com/hauntsaninja/mypy/tree/py39
Analogous commit on that branch: hauntsaninja@9c985ba

Separately, some stuff still needs to happen to get CI green for Python 3.9, see https://bugs.python.org/issue40349. We should probably start tracking stuff come beta.

@hauntsaninja
Copy link
Collaborator

This should be closed, since we merged #8716

@JelleZijlstra
Copy link
Member

Thanks for your contribution @CyberSaxosTiGER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants