-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Enable output color and effects on Windows #7463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it is great to have good support across all platforms! I just have couple small suggestions.
Have you checked that get_terminal_width()
works as expected and there are no problems with the daemon?
Huh, that's concerning. I'm not sure why the daemon timeouts happened. I triggered a new build so hopefully that was a fluke (but I will think about why that could happen). |
The problem may be because if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updates!
I have couple more comments (feel free to land after you consider them).
It turns out it is relatively simple to do this on Windows 10 without dependencies. Note that we can get color output on Windows 7/8 but not really underlining or other VT100 features. This should be supported on all versions of Windows 10 people are running. I'm not sure Windows 7/8 support is worth it here. Windows 7 is EOL at the end of the year, and Windows 8.1 has only 5% market share.
Fixes #7437