Format suggestions using the "signature" pyannotate format instead #7415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
force-pushed
the
suggest-signature
branch
from
6552a73 to
f084d92
Compare
This bypasses pyannotate's parsing and processing of annotations and allows us to just specify them directly. This is useful because pyannotate doesn't support Callable.
msullivan
force-pushed
the
suggest-signature
branch
from
f084d92 to
61c40e8
Compare
ilevkivskyi
approved these changes
Aug 31, 2019
| @@ -247,7 +253,11 @@ def get_args(self, is_method: bool, | |||
| if default: | |||
| all_arg_types.append(default) | |||
|
|
|||
| if all_arg_types: | |||
| if len(all_arg_types) == 1 and isinstance(get_proper_type(all_arg_types[0]), NoneType): | |||
There was a problem hiding this comment.
Generally this is good idea, this is consistent to what stubgen does. But why do we need to check that length is 1? This is not a set, how do we know all the types are unique there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bypasses pyannotate's parsing and processing of annotations
and allows us to just specify them directly. This is useful because
pyannotate doesn't support Callable.