dmypy suggest: handful of bug fixes/improvements #6997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix --no-any to not spuriously reject all methods * Support inferring types of decorated methods if the decorator doesn't change the type * Refuse to infer functions with then or more arguments to avoid spending forever calculating an exponentially large number of possibilities before deciding there are too many possibilities.
gvanrossum
approved these changes
Jun 17, 2019
mypy/suggestions.py
Outdated
| if not isinstance(node, FuncDef): | ||
| raise SuggestionFailure("Object %s is not a function" % key) | ||
|
|
||
| return (modname, tail, node) | ||
|
|
||
| def extract_from_decorator(self, node: Decorator) -> Optional[FuncDef]: | ||
| for dec in node.decorators: | ||
| print(dec) |
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
* Fix --no-any to not spuriously reject all methods * Support inferring types of decorated methods if the decorator doesn't change the type * Refuse to infer functions with then or more arguments to avoid spending forever calculating an exponentially large number of possibilities before deciding there are too many possibilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doesn't change the type
spending forever calculating an exponentially large number of
possibilities before deciding there are too many possibilities.
I've already successfully used this code in generating annotations at Dropbox.