New semantic analyzer: fix type promotions special cases #6609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up type promotions after the main semantic analyzer pass to avoid the need to defer. This fixes an issue with test stubs, but the existing approach probably worked with typeshed. Another benefit of this approach is that things are easier to reason about, as the main semantic analysis pass is a bit simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up type promotions after the main semantic analyzer pass to
avoid the need to defer. This fixes an issue with test stubs,
but the existing approach probably worked with typeshed.
Another benefit of this approach is that things are easier to
reason about, as the main semantic analysis pass is a bit
simpler.
This fixes the
testDivmodtype checker test case.