Skip to content

New semantic analyzer: Report undefined names in function types #6479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

ilevkivskyi
Copy link
Member

Fixes #6425

The idea is straightforward (and the same as for assignments), don't store analyzed type if there are incomplete refs encountered.

Daemon support is blocked on this since we depend on reprocessing targets with errors.

@ilevkivskyi ilevkivskyi changed the title New report func errors New semantic analyzer: Report undefined names in function types Feb 25, 2019
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge once the builds are green.

@ilevkivskyi ilevkivskyi merged commit 8db9ce5 into python:master Feb 25, 2019
@ilevkivskyi ilevkivskyi deleted the new-report-func-errors branch February 25, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants