Skip to content

New semantic analyzer: report undefined types in signatures #6425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JukkaL opened this issue Feb 18, 2019 · 0 comments
Closed

New semantic analyzer: report undefined types in signatures #6425

JukkaL opened this issue Feb 18, 2019 · 0 comments
Assignees
@ilevkivskyi
Labels
priority-0-high semantic-analyzer Problems that happen during semantic analysis

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Feb 18, 2019

Currently undefined types in function annotations don't generate an error when using the new semantic analyzer. Example:

def f(x: adsf) -> None:  # No error
    pass
@JukkaL JukkaL added priority-0-high semantic-analyzer Problems that happen during semantic analysis labels Feb 18, 2019
@ilevkivskyi ilevkivskyi self-assigned this Feb 25, 2019
@ilevkivskyi ilevkivskyi mentioned this issue Feb 25, 2019
Merged
ilevkivskyi added a commit that referenced this issue Feb 25, 2019
@ilevkivskyi
New semantic analyzer: Report undefined names in function types (#6479)
8db9ce5 
Fixes #6425

The idea is straightforward (and the same as for assignments), don't store analyzed type if there are incomplete refs encountered.

Daemon support is blocked on this since we depend on reprocessing targets with errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilevkivskyi ilevkivskyi

Labels
priority-0-high semantic-analyzer Problems that happen during semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JukkaL @ilevkivskyi