Remove a mypyc hack that became a liability #6392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removed the sys.platform hack, the dummy `bool()` in a unreachable code hack became, itself, unreachable. And while mypyc is much better about unreachable branches that it used to be, it still crashes on unreachable parts of conditional expressions.
|
This will fix OS X mypy-mypyc builds, which I just broke in #6365 |
emmatyping
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removed the sys.platform hack, the dummy
bool()ina unreachable code hack became, itself, unreachable.
And while mypyc is much better about unreachable branches that it used
to be, it still crashes on unreachable parts of conditional
expressions.