Allow OverloadedFuncDef to have no items #6174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Jan 10, 2019
| self.items = items | ||
| self.unanalyzed_items = items.copy() | ||
| self.impl = None | ||
| self.set_line(items[0].line) | ||
| if len(items) > 0: | ||
| self.set_line(items[0].line) |
There was a problem hiding this comment.
Maybe try using self.impl to set line, like in the name() method just below?
There was a problem hiding this comment.
That does not work, as self.impl is None at this point (see line above).
There was a problem hiding this comment.
OK, I see, maybe then set line in deserialize() method below? For example under the if data.get('impl') is not None: branch if items is empty (with a comment explaining that if overload items are empty then the line will not be set in __init__).
There was a problem hiding this comment.
Good idea, I added it, works for me locally 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested this locally, works for me, but I'm not sure if this assertion is necessary for something else.
Fixes #6108