Skip to content

Fix verbosity issue in DataDrivenTestCase #5731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

elazarg
Copy link
Contributor

@elazarg elazarg commented Oct 4, 2018

Fix issue caused by #5459: .file was initialized lazily thus reported as empty. The fix is the assignment to self.file in the constructor. The field path is redundant.

There is no progress indication in the output:

mypy/test/testargs.py::ArgSuite::test_coherence PASSED
mypy/test/testargs.py::ArgSuite::test_executable_inference PASSED
mypy/test/testcheck.py::TypeCheckSuite::testEmptyFile <- /Users/elazarg/workspace/mypy/test-data/unit/check-basic.test PASSED
mypy/test/testcheck.py::TypeCheckSuite::testAssignmentAndVarDef <- /Users/elazarg/workspace/mypy/test-data/unit/check-basic.test PASSED

Additionally

  • Renamed path consistently to file. I would prefer the former, but .file is used by unit tests.
  • Since parse_test_case is effectively a setup method, it is more consistent not to pretend to pass it any argument other than case=self.

@msullivan @gvanrossum

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@gvanrossum gvanrossum merged commit 6686d25 into python:master Oct 4, 2018
TV4Fun pushed a commit to TV4Fun/mypy that referenced this pull request Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants