-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Lazy tests: parse using regex first #5459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a0956c0
to
999db69
Compare
- change 'skip-cache' to 'only_when_nocache' and similarly 'skip-nocache'
999db69
to
cbe61c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the big delay in reviewing this.
The speedups for running single tests will be really nice and I am happy with the approach here.
Could you go ahead and get rid of the if True
s and then we can merge this?
Additional refactoring and cleanup:
|
Linux 3.4 / 3.5.1 seem to fail spuriously - "Unable to download 3.5.1 archive"? (The windows tests fail due to path separator on the expected output being reversed when it shouldn't) |
I've restarted the linux builds |
Thank you! |
Since this PR landed,
Previously it would print the test name instead of the string
Methinks something went wrong here. @elazarg do you have a hunch as to what caused this? (I feel I've done enough research by bisecting it to this PR.) |
Of course. Sorry! |
Fix #1073: parse tests on collection only enough to find the name, so small number of tests run faster
On my machine,
pytest -n0 -k testAttrsSimple
takes at least 2.24 seconds to finish on master, and at most 0.95 seconds to finish with this PR.