Skip to content

Mention exception for generic type aliases #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Mention exception for generic type aliases #5478

merged 2 commits into from
Aug 14, 2018

Conversation

asottile
Copy link
Contributor

No description provided.

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor suggestion.

@@ -546,7 +546,8 @@ assigning the type to a variable:
.. note::

A type alias does not create a new type. It's just a shorthand notation for
another type -- it's equivalent to the target type.
another type -- it's equivalent to the target type except for
:ref:`generic-type-aliases`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather format this as :ref:`generic aliases <generic-type-aliases>`

@ilevkivskyi ilevkivskyi merged commit 5c0394e into python:master Aug 14, 2018
@asottile asottile deleted the docs_generic_type_aliases branch August 14, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants