Support for Ellipsis and ... #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,6 +146,7 @@ def __init__(self, string: str, type: int) -> None: | |||
| INVALID_UTF8_SEQUENCE = 5 | |||
| INVALID_BACKSLASH = 6 | |||
| INVALID_DEDENT = 7 | |||
| ELLIPSIS_ERROR = 8 | |||
There was a problem hiding this comment.
I don't think that this is needed (see below) since we'll get a parse error if ellipsis is used incorrectly.
|
Did a quick pass (see my comments), but looks mostly good. It's a bit sad how many changes such as simple feature requires... but they are all straightforward, so it's not a big deal. The lexer and parser could be rewritten at some point to be rule-based, but it's a bit pointless do it now as there are way more urgent things to work on. |
|
Good suggestions. I've taken them along. |
|
Looks good to me! Thanks for implementing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Python 3 specific support for ellipsis. See test cases for examples.
I have some doubt about the way I introduced the
ellipsisclass, which is the type of...andEllipsis. I've added it as a class tobuiltins.py, however, that makes code likea = ellipsis()legal, which it is not. I don't know how to haveellipsisas a class, while at the same time hiding it.Fixes #524.