Only apply overloading union math to "real" unions #5239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Jun 19, 2018
test-data/unit/python2eval.test
Outdated
| @@ -401,3 +401,13 @@ def f(): # no annotation | |||
| path = 'test' | |||
| path = os.path.join(f(), 'test.py') | |||
| [out] | |||
|
|
|||
| [case testOverloadRelpathRegression] | |||
There was a problem hiding this comment.
This test case seems unnecessary as we have two test cases that cover this already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By "real" unions I mean unions with more than one relevant item.
Fixes #5238
(I have found another bug in union math logic while looking at this code, but it is a bit more subtle, so we will fix it separately).