Fix overload interaction with Any #5233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2018 20:44
Michael0x2a
approved these changes
Jun 18, 2018
mypy/checkexpr.py
Outdated
| if all(is_subtype(ret_type, return_types[-1]) for ret_type in return_types[:-1]): | ||
| if all(is_subtype(ret_type, return_types[-1]) and | ||
| is_subtype(return_types[-1], ret_type) | ||
| for ret_type in return_types[:-1]): | ||
| # The last match is a supertype of all the previous ones, so it's safe | ||
| # to return that inferred type. |
There was a problem hiding this comment.
We should probably update this comment. Other then that, lgtm
|
@JukkaL This reduces the number of errors in internal code bases, only five left in C (and all look like the same error). S however still has lots of errors because of typeshed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5232
This also makes few minor amendments to
pythonevaltests.