Preserve the name of first argument in methods when serializing #5109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The lint issue seemed minor so I went ahead and fixed it. I can confirm this solves the issue I came across in #1412! |
msullivan
approved these changes
May 25, 2018
There was a problem hiding this comment.
A good start on the infrastructure for this.
Updating the interface hashing is going to be annoying. One kind of hacky approach would be after formatting the json, traverse the serialized tree sanitizing it by deleting def_extras, then hash the formatting of that.
mypy/types.py
Outdated
| bound_args=[(None if t is None else deserialize_type(t)) | ||
| for t in data['bound_args']], | ||
| ) | ||
| call_type.def_extras = data['def_extras'] |
There was a problem hiding this comment.
Would it be cleaner to add def_extras to the __init__?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to give nicer error messages after serialization.
This is a step towards #4772
Unblocks #1412 (much faster
pythonevaltests).