Fine-grained: Fix crashes due to stale dependencies #4725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could have a dependency pointing to a target that no longer was valid, and various assertions could be triggered, causing a crash. Now we just filter out bad targets to avoid crashes. Fixes #4723 and other related issues.
msullivan
approved these changes
Mar 13, 2018
| @@ -458,7 +458,7 @@ def set_line(self, target: Union[Context, int], column: Optional[int] = None) -> | |||
|
|
|||
|
|
|||
| class FuncItem(FuncBase): | |||
| arguments = [] # type: List[Argument] | |||
| arguments = [] # type: List[Argument] # Note: Can be None if deserialized (type is a lie!) | |||
test-data/unit/fine-grained.test
Outdated
| @@ -2832,3 +2832,148 @@ class C(Enum): | |||
| == | |||
| a.py:4: error: Argument 1 to "f" has incompatible type "C"; expected "int" | |||
| a.py:5: error: Argument 1 to "f" has incompatible type "C"; expected "int" | |||
|
|
|||
There was a problem hiding this comment.
Which tests hit partially deserialized nodes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have a dependency pointing to a target that is no longer valid,
and this could trigger various assertions, causing a crash. Now we just
filter out bad targets to avoid crashes.
Fixes #4723 and other related issues.