Fix dep generation of super() and class names #4513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class names need to generate dependencies to __init__ even when not directly being called, since they could be passed elsewhere and called. We generate spurious dependencies in cases such as classes being referenced in isinstance checks and expect statements, but that's not a big deal. Handling super() deps is bundled in with this because the __init__ fix broke a super() using test that previously worked somewhat by accident.
JukkaL
approved these changes
Jan 26, 2018
mypy/server/deps.py
Outdated
|
|
||
| # If this is a reference to a type, generate a dependency to its | ||
| # constructor. This will be spurious in cases like isinstance | ||
| # calls and except statements, but that's no big deal. |
There was a problem hiding this comment.
What about class attribute references? If things like Foobar.method() depend on FooBar.__init__, this could have performance implications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class names need to generate dependencies to init even when not
directly being called, since they could be passed elsewhere and
called. We generate spurious dependencies in cases such as classes
being referenced in isinstance checks and expect statements, but
that's not a big deal.
Handling super() deps is bundled in with this because the init fix
broke a super() using test that previously worked somewhat by accident.