ListExpr is not an lvalue anymore #4342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a python2 test and a test with a list lvalue and a |
elazarg
force-pushed
the
tuple-lvalue
branch
3 times, most recently
from
96ac9e1 to
c06d2ea
Compare
|
Thanks! Indeed there was a Python2 bug :) |
|
For what it's worth, I think this is a cool change that should be merged. |
msullivan
requested changes
Jan 26, 2018
| return ListExpr([self.visit(e) for e in n.elts]) | ||
| def visit_List(self, n: ast3.List) -> Union[ListExpr, TupleExpr]: | ||
| expr_list = [self.visit(e) for e in n.elts] # type: List[Expression] | ||
| if isinstance(n.ctx, ast3.Store): |
There was a problem hiding this comment.
Could you add a quick comment here and in fastparse2 explaining why?
msullivan
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4340 by considering TupleExpr as the only lvalue sequence.
(And maybe one day it will be LvalueSeq)