Skip to content

Conversation

graingert
Copy link
Contributor

No description provided.

@gvanrossum
Copy link
Member

Even if we all end up agreeing this is not needed let's not land it before 0.521 is released.

@emmatyping emmatyping requested a review from ddfisher July 11, 2017 00:20
@emmatyping
Copy link
Member

emmatyping commented Jul 11, 2017

I agree with @gvanrossum. Also to be clear about the rational (for now and posterity), even though typed-ast is binary, mypy is pure Python, so platform specific wheels are not needed. It doesn't hurt to have extra wheels, but they just churn extra CI time.

(Also I asked David for your review since you put the platform build in, and wanted to make sure we werent missing anything.)

@graingert
Copy link
Contributor Author

graingert commented Jul 11, 2017

It doesn't hurt to have extra wheels

As you mentioned they add extra CI time, they also:

Waste of bytes on PyPI
May cause confusion, people may thing they need to build bdists for linux/mac to install mypy
May cause problems with tooling that make assumptions about universal wheels implying no other wheels.

@ddfisher
Copy link
Collaborator

@gvanrossum do you remember why we started having platform-specific wheels in the first place?

@gvanrossum
Copy link
Member

@ddfisher I don't recall, I thought there was some tiny essential difference that you once explained to me (maybe it was just the filename itself). I definitely recall being surprised at first but someone (either you or Jukka) convinced me that it was necessary.

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 11, 2017

My understanding is that this commit by @ethanhs made it possible to use only a single wheel: 166d54d Previously setup.py worked differently on Windows compared to other platforms.

@emmatyping
Copy link
Member

Ah, I believe that would do it. Before if you built on Linux it wouldn't copy the Windows script into the wheel or visa versa. Now that isnt a problem because setuptools handles the script on install I think.

@graingert
Copy link
Contributor Author

Now that isnt a problem because setuptools handles the script on install I think.

yup

@gvanrossum gvanrossum merged commit 9488e38 into python:master Aug 22, 2017
@gvanrossum
Copy link
Member

Sorry for the delay! 0.521 has been out of the door for weeks and we haven't heard any complaints so I think we're good here.

@graingert
Copy link
Contributor Author

Wheely great news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants