-
-
Notifications
You must be signed in to change notification settings - Fork 3k
no need for windows artifacts, we're universal #3691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Even if we all end up agreeing this is not needed let's not land it before 0.521 is released. |
I agree with @gvanrossum. Also to be clear about the rational (for now and posterity), even though typed-ast is binary, mypy is pure Python, so platform specific wheels are not needed. It doesn't hurt to have extra wheels, but they just churn extra CI time. (Also I asked David for your review since you put the platform build in, and wanted to make sure we werent missing anything.) |
As you mentioned they add extra CI time, they also: Waste of bytes on PyPI |
@gvanrossum do you remember why we started having platform-specific wheels in the first place? |
@ddfisher I don't recall, I thought there was some tiny essential difference that you once explained to me (maybe it was just the filename itself). I definitely recall being surprised at first but someone (either you or Jukka) convinced me that it was necessary. |
Ah, I believe that would do it. Before if you built on Linux it wouldn't copy the Windows script into the wheel or visa versa. Now that isnt a problem because setuptools handles the script on install I think. |
yup |
Sorry for the delay! 0.521 has been out of the door for weeks and we haven't heard any complaints so I think we're good here. |
Wheely great news! |
No description provided.