fix flake8-pyi python_version conditional in test-requirements #3398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flake8-pyi only works with 3.6 right now, so installing it alongside python3.5 results in a test failure when it is imported.
|
I'm going to spend a bit of time trying to get flake8-pyi to work on 3.5 (cc @ambv); let's merge this PR if that doesn't work out. |
|
OK, blocked until @JelleZijlstra says it's unblocked. |
|
I've given up on making flake8-pyi work in 3.5 (see the linked flake8-pyi PR), so unless Lukasz has another preference I'm OK with merging this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8-pyi only works with 3.6 right now, so installing it alongside
python3.5 results in a test failure when it is imported.