Add line # of previous definition #3396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
requested changes
May 22, 2017
mypy/semanal.py
Outdated
| def name_already_defined(self, name: str, ctx: Context, | ||
| original_ctx: Optional[SymbolTableNode] = None) -> None: | ||
| if original_ctx: | ||
| extra_msg = ' in line {}'.format(original_ctx.node.get_line()) |
There was a problem hiding this comment.
Can you make this "on line {}" ?
gvanrossum
approved these changes
May 22, 2017
|
Thanks -- I'll merge once the tests pass! |
Closed
gvanrossum
added a commit
that referenced
this pull request
May 23, 2017
This reverts commit 05521e4.
JukkaL
pushed a commit
that referenced
this pull request
May 23, 2017
JukkaL
pushed a commit
that referenced
this pull request
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #1874 - just improve the error message. The duplicate definitions in different if/else branches are still not allowed.