Allow importing NoReturn from typing #3041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-data/unit/check-flags.test
Outdated
| def f() -> NoReturn: | ||
| no_return() | ||
|
|
||
| x = 0 # type: NoReturn # E: Incompatible types in assignment (expression has type "int", variable has type NoReturn) |
Member
There was a problem hiding this comment.
Does x = ... # type: NoReturn also produce an error?
Also, this error should happen even without --warn-no-return, so maybe it should be a separate test case.
Member
Author
There was a problem hiding this comment.
You are right, --warn-no-return is now on by default, so that I just removed it.
x: NoReturn doesn't produce an error (and probably shouldn't) so I just use x: NoReturn = 0
Member
Author
|
I think it is completely safe to merge this now (both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoReturnwas added to PEP 484 recently, and will be added totypingright after Python 3.6.1 release.This PR allows to import
NoReturnfromtypingin addition tomypy_extensions.