Update typeshed #2551
Closed
Update typeshed #2551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea what you did here, but it doesn't sound right. Normally when you do "git submodule update" the diff comes out as a one-line change to a commit hash in a "file" named typeshed. See every other diff with commit message "sync typeshed". |
|
I wonder if this is just a new github UI feature that shows changes in the typeshed repo? |
|
OK, I'll see if this works with our internal codebases and if so merge it. |
|
There's one problem due to #726, otherwise it's clean. I'm looking into it. |
|
It's because FrozenSet should be covariant. I'm doing that in python/typeshed#769. |
|
I'm going to make a new PR to sync to the latest typeshed and merge that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.