Skip to content

Attempted fix for crash with runtime generics #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ilevkivskyi
Copy link
Member

No description provided.

@gvanrossum
Copy link
Member

Yes, this makes the error go away (but I'm not sure how :-).

@codecov-io
Copy link

codecov-io commented Oct 24, 2016

Current coverage is 83.17% (diff: 0.00%)

Merging #2309 into master will decrease coverage by 0.02%

@@             master      #2309   diff @@
==========================================
  Files            72         72          
  Lines         19047      19052     +5   
  Methods           0          0          
  Messages          0          0          
  Branches       3920       3922     +2   
==========================================
  Hits          15847      15847          
- Misses         2605       2608     +3   
- Partials        595        597     +2   

Powered by Codecov. Last update 5b2d3b3...5e4a330

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better check would be to check whether it's a Callable before casting?

Also the hasattr() looks a bit desperate. :-)

@gvanrossum
Copy link
Member

Closing in favor of #2333.

@gvanrossum gvanrossum closed this Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants