Make mypy still check imports with # type: ignore comments if the import exists
#1912
Conversation
| if self.errors.num_messages() != num_errs: | ||
| self.log("Bailing due to parse errors") | ||
| self.errors.raise_error() | ||
|
|
||
| # We don't want to warn about 'type: ignore' comments on imports |
There was a problem hiding this comment.
I think this should be "... about unused '# type: ignore' comments ...". Also please clarify that this is because an import might be valid on some platform and invalid on another.
(Come to think of it, that could in theory also be a concern with --warn-unused-ignores in other places, but much less probable.)
There was a problem hiding this comment.
I don't think this is the right decision. You're not intended to always run with --warn-unused-ignores in CI, for example, because this can be a problem in other places (like when you're transitioning between mypy releases). --warn-unused-ignores is intended to be run periodically to clean up unnecessary # type: ignore comments and is intended to require human judgement in the loop. If something is even just potentially unused, we should warn about it here.
Put another way: if we don't warn about type ignore comments on imports, they'll never be removed.
There was a problem hiding this comment.
Maybe, but this is how it already works (Michael just updated the comment and moved the line). If you feel strongly about this please file a separate bug.
There was a problem hiding this comment.
It only worked that way before because a # type: ignore on an import always had an effect. Filed #1913.
This pull request fixes #1911. It also incidentally fixes #1904, which means that we can close #1906 since it's superseded by this pull request. However, this pull request does NOT fix issue #1910, which appears to be an unrelated bug.