Do not pass message builder to analyze_member_access #18818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Mar 20, 2025
ngnpope
added a commit
to ngnpope/django-stubs
that referenced
this pull request
May 9, 2025
In python/mypy#18818 the `msg` argument to `analyze_member_access()` was removed.
sobolevn
pushed a commit
to typeddjango/django-stubs
that referenced
this pull request
May 9, 2025
* Fix a crash on mypy master branch In python/mypy#18818 the `msg` argument to `analyze_member_access()` was removed. * Switch to using a version-based check
asottile-sentry
pushed a commit
to getsentry/sentry-forked-django-stubs
that referenced
this pull request
Jun 3, 2025
* Fix a crash on mypy master branch In python/mypy#18818 the `msg` argument to `analyze_member_access()` was removed. * Switch to using a version-based check
jose-reveni
pushed a commit
to jose-reveni/django-stubs
that referenced
this pull request
Jun 9, 2025
* Fix a crash on mypy master branch In python/mypy#18818 the `msg` argument to `analyze_member_access()` was removed. * Switch to using a version-based check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure refactoring so I am not waiting for a review.