Fix crash when function annotation has more args than function with fast parser #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently crash when we have a function type comment that has more arguments than the function itself when running with the fast parser. We actually already check for this error in two places: in the normal parser (which doesn't affect this case) and in the semantic analysis phase. When the error is caught in the normal parser, this aborts further processing (because it's considered a parse error). This PR makes the check in the semantic analysis phase produce a blocking error, which aborts further processing and prevents the crash later down the line (where the number of arguments is assumed to match).