Allow defining type aliases for Optional[T] #1653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required some follow-on changes that I don't totally understand, but seem like simplifications.
| res = analyze_type_alias(s.rvalue, | ||
| self.lookup_qualified, | ||
| self.lookup_fully_qualified, | ||
| self.fail) | ||
| if res and (not isinstance(res, Instance) or cast(Instance, res).args): | ||
| if res: |
There was a problem hiding this comment.
IIUC the code you removed here was added in ab4a0fe and while some of the surrounding code was changed, it seems to guard against using e.g. List[AnyStr]. Can you check that either that's still prohibited or it actually works as expected?
|
I checked manually that List[AnyStr] is still considered invalid. So merging. |
|
It looks like this breaks type aliases defined inside of classes. I'm going to revert for now. |
ddfisher
added a commit
that referenced
this pull request
Jun 6, 2016
This reverts commit cd5876c because it breaks type aliases inside of classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required some follow-on changes that I don't totally understand,
but seem like simplifications.