Acknowledge __all__ #1640
Merged
Acknowledge __all__ #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have some CI failures; "mypy mypy" fails and a few tests also fail (perhaps as fallout). |
| @@ -159,6 +159,8 @@ class SemanticAnalyzer(NodeVisitor): | |||
| modules = None # type: Dict[str, MypyFile] | |||
| # Global name space for current module | |||
| globals = None # type: SymbolTable | |||
| # Globals that were mentioned in __all__ and should be module_public. | |||
| global_exports = set() | |||
There was a problem hiding this comment.
This variable is unused. Maybe you changed your mind and named it all_exports later?
There was a problem hiding this comment.
Also a mutable default is a bad idea.
|
@gvanrossum Fixed! Do you want me to squash the commits? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1606. Took me a bit of experimentation to figure out where to put the code...