[mypyc] Make tuple packing and unpacking more efficient #16022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously returning a tuple from a function resulted in redundant increfs and decrefs
for each item, and similarly unpacking the returned tuple in an assignment had extra
incref/decref pair per item. This PR introduces these changes to make this better:
Unborrow
op.KeepAlive
op can steal the operands to avoid decrefing the operands.Assignment from tuple now uses the three final features to avoid increfs and decrefs
when unpacking a tuple in assignment. The docstrings in this PR contain additional
explanation of how this works.
In a micro-benchmark this improved performance by about 2-5%. In realistic examples
the impact is likely small, but every little helps.
Here is an example where this helps: