Add foundation to enable --strict-optional in all test files
#15586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
reviewed
Jul 4, 2023
This was referenced Jul 5, 2023
JelleZijlstra
pushed a commit
that referenced
this pull request
Jul 6, 2023
Followup to #15586 Co-authored-by: Shantanu <[email protected]>
This was referenced Jul 6, 2023
JukkaL
pushed a commit
that referenced
this pull request
Jul 7, 2023
JelleZijlstra
pushed a commit
that referenced
this pull request
Jul 7, 2023
Followup to #15586 This will be the last one 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
--strict-optionalin all test files would require a lot of changes currently. This PR adds a blacklist for test files which still require--no-strict-optional. It will allow us to update those incrementally.The same could be done for the
force_uppercase_builtinsandforce_union_syntaxsettings afterwards.