Correctly type check redefinitions in try's else clause. #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1758,9 +1758,6 @@ def visit_try_stmt(self, s: TryStmt) -> Type: | |||
| self.binder.try_frames.add(len(self.binder.frames) - 2) | |||
| self.accept(s.body) | |||
| self.binder.try_frames.remove(len(self.binder.frames) - 2) | |||
| if s.else_body: | |||
| self.accept(s.else_body) | |||
| self.breaking_out = False | |||
There was a problem hiding this comment.
I suspect that self.breaking_out = False should be left here. I can try to come up with a test case, but if nothing breaks, I'd leave it.
|
OK, added it back. I was wondering about that; it's unclear even after scanning all the code exactly how this flag is used. |
|
The exact semantics aren't entirely clean to me either. They way I understand it is that it will be true when statements following the current statement can't be reached -- for example, after a return statement. It gets trickier when there is non-trivial control flow such as within a try statement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1289. After a diff in the issue by @Brodie.