Support debug prints in mypy daemon #13769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture stdout in daemon and display it in the client. This makes it possible to use debug prints in the daemon end-to-end. They previously only worked in daemon test cases.
ilevkivskyi
approved these changes
Sep 29, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JukkaL
added a commit
that referenced
this pull request
Feb 24, 2023
Previously stdout from mypy daemon was propagated to the client, but some verbose logging is written to stderr and it wasn't propagated. Now propagate stderr as well. Tested manually. This builds on top of #13769.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture stdout in daemon and display it in the client. This makes it possible to use debug prints in
the daemon when doing end-to-end testing. They previously only worked in daemon test cases.