Skip to content

Remove bound_vars field of CallableType #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2016

Conversation

rwbarton
Copy link
Contributor

This field was effectively unused since the removal of the runtime
type checking target in commit 6dca530 "Remove obsolete
transform-related code".

This field was effectively unused since the removal of the runtime
type checking target in commit 6dca530 "Remove obsolete
transform-related code".
@gvanrossum gvanrossum merged commit 2db9dc3 into python:master Apr 13, 2016
@gvanrossum
Copy link
Member

I love the smell of deleted code in the morning!

Interesting that the last remaining use was in __repr__() of CallableType.

@gnprice
Copy link
Collaborator

gnprice commented Apr 14, 2016

Nice diffstat. :-)

It looks like a couple of these methods still indicate in their docstrings that they do something with these -- probably good to cut those too so they don't confuse someone in the future who doesn't know what an "implicit bound type" is supposed to be.

$ git grep -n implicit.*bound
mypy/applytype.py:15:    'def [-1:int] (int) -> int'. Here '[-1:int]' is an implicit bound type
mypy/types.py:936:     - Include implicit bound type variables of callables.

@rwbarton
Copy link
Contributor Author

Good point Greg. I filed #1385.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants