Implement basic typevartuple constraints/inference #12688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Apr 28, 2022
mypy/checkexpr.py
Outdated
| @@ -1019,13 +1019,22 @@ def check_callable_call(self, | |||
| callee.arg_kinds, callee.arg_names, | |||
| lambda i: self.accept(args[i])) | |||
|
|
|||
| print(callee) | |||
| print(callee.variables) | |||
There was a problem hiding this comment.
Remove debug prints (here and below).
mypy/constraints.py
Outdated
| @@ -694,6 +694,30 @@ def infer_against_overloaded(self, overloaded: Overloaded, | |||
|
|
|||
| def visit_tuple_type(self, template: TupleType) -> List[Constraint]: | |||
| actual = self.actual | |||
| print("XX") | |||
mypy/infer.py
Outdated
| @@ -46,6 +46,8 @@ def infer_function_type_arguments(callee_type: CallableType, | |||
| # Infer constraints. | |||
| constraints = infer_constraints_for_callable( | |||
| callee_type, arg_types, arg_kinds, formal_to_actual, context) | |||
| print("constraints") | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JukkaL
approved these changes
Apr 29, 2022
|
|
||
| reveal_type(g(args, args)) # N: Revealed type is "Tuple[builtins.int, builtins.str]" | ||
| reveal_type(g(args, args2)) # N: Revealed type is "Tuple[builtins.int, builtins.str]" | ||
| reveal_type(g(args, args3)) # N: Revealed type is "builtins.tuple[builtins.object, ...]" |
There was a problem hiding this comment.
These are against the PEP -- we should not take a join when inferring TypeVarTuples. But we can revisit this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements basic inference for TypeVarTuple along with various
checktests verifying uses ofTypeVarTuplewith functions works reasonably.