Pep561 tests seem to work on mac #11325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase on #11324 |
nipunn1313
force-pushed
the
worksonmac
branch
from
473932f to
3983d2c
Compare
|
Possibly a thing that was fixed by #10855 ? Ethan would know for sure |
JelleZijlstra
approved these changes
Oct 13, 2021
|
The original issue was found by @msullivan IIRC, where on Mac, if one was already in a virtualenv, the venv tests would fail spuriously. It very well may have been fixed by #10855, but I don't have a Mac system to test. |
|
I ran the tests both inside and outside a virtualenv on a mac. Maybe I'm
not reproing the condition exactly? Either way, ok with landing this
optimistically
…On Wed, Oct 13, 2021 at 1:04 AM Ethan Smith ***@***.***> wrote:
The original issue was found by @msullivan <https://github.com/msullivan>
IIRC, where on Mac, if one was already in a virtualenv, the venv tests
would fail spuriously. It very well may have been fixed by #10855
<#10855>, but I don't have a Mac
system to test.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11325 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ5PI4CCCDWHD3RORV4ZHDUGU4SBANCNFSM5F4ADPNQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Let's give this a try. |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that these tests work for me on mac. Perhaps @ethanhs might be able to speak to the original reasoning here? Possibly I don't have the setup that reproes the problem?