Hopeful fix for #1002 (lxml trouble). #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2016
|
The declaration is optional so I assume that this should be okay. |
|
We don't have tests for any XML stuff -- did you try that you can generate type checking coverage reports? |
|
Verified that it still generates reports. There are some other report issues but they were pre-existing. |
gvanrossum
added a commit
that referenced
this pull request
Jan 13, 2016
Hopeful fix for #1002 (lxml trouble).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the stated error with lxml version 3.5.0. But the generated XML files don't contain
<?xml version="1.0" encoding="UTF-8" ?-- is that a problem?