Skip to content

Double quotes in errors messages #10525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 22, 2021
Merged

Conversation

dixith
Copy link
Contributor

@dixith dixith commented May 22, 2021

Description

This pull request fixes issue reported in #7445 for below errors:

  1. does not explicitly export attribute
  2. Unsupported format character
  3. key not found in mapping
  4. Format character support
  5. Unexpected keyword argument
  6. plugin related errors
  7. return with value in async
  8. cant pass both
  9. not supported

Test Plan

Updated test cases for the message. New test cases not added.

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

streamlit (https://github.com/streamlit/streamlit.git)
- lib/tests/streamlit/script_request_queue_test.py:23:1: error: Module 'streamlit.script_runner' does not explicitly export attribute 'ScriptRequest'; implicit reexport disabled  [attr-defined]
+ lib/tests/streamlit/script_request_queue_test.py:23:1: error: Module "streamlit.script_runner" does not explicitly export attribute "ScriptRequest"; implicit reexport disabled  [attr-defined]
- lib/tests/streamlit/config_option_test.py:20:1: error: Module 'streamlit.config_option' does not explicitly export attribute 'DeprecationError'; implicit reexport disabled  [attr-defined]
+ lib/tests/streamlit/config_option_test.py:20:1: error: Module "streamlit.config_option" does not explicitly export attribute "DeprecationError"; implicit reexport disabled  [attr-defined]
- lib/tests/streamlit/report_queue_test.py:21:1: error: Module 'streamlit' does not explicitly export attribute 'RootContainer'; implicit reexport disabled  [attr-defined]
+ lib/tests/streamlit/report_queue_test.py:21:1: error: Module "streamlit" does not explicitly export attribute "RootContainer"; implicit reexport disabled  [attr-defined]
- lib/tests/streamlit/text_input_test.py:20:1: error: Module 'streamlit' does not explicitly export attribute 'StreamlitAPIException'; implicit reexport disabled  [attr-defined]
+ lib/tests/streamlit/text_input_test.py:20:1: error: Module "streamlit" does not explicitly export attribute "StreamlitAPIException"; implicit reexport disabled  [attr-defined]
- lib/tests/streamlit/report_test.py:23:1: error: Module 'streamlit' does not explicitly export attribute 'RootContainer'; implicit reexport disabled  [attr-defined]
+ lib/tests/streamlit/report_test.py:23:1: error: Module "streamlit" does not explicitly export attribute "RootContainer"; implicit reexport disabled  [attr-defined]
- lib/tests/streamlit/forward_msg_cache_test.py:20:1: error: Module 'streamlit' does not explicitly export attribute 'RootContainer'; implicit reexport disabled  [attr-defined]
+ lib/tests/streamlit/forward_msg_cache_test.py:20:1: error: Module "streamlit" does not explicitly export attribute "RootContainer"; implicit reexport disabled  [attr-defined]
- lib/tests/streamlit/server_test.py:29:1: error: Module 'streamlit' does not explicitly export attribute 'RootContainer'; implicit reexport disabled  [attr-defined]
+ lib/tests/streamlit/server_test.py:29:1: error: Module "streamlit" does not explicitly export attribute "RootContainer"; implicit reexport disabled  [attr-defined]
- lib/tests/streamlit/components_test.py:27:1: error: Module 'streamlit' does not explicitly export attribute 'StreamlitAPIException'; implicit reexport disabled  [attr-defined]
+ lib/tests/streamlit/components_test.py:27:1: error: Module "streamlit" does not explicitly export attribute "StreamlitAPIException"; implicit reexport disabled  [attr-defined]
- lib/tests/streamlit/bootstrap_test.py:26:1: error: Module 'streamlit' does not explicitly export attribute 'SECRETS_FILE_LOC'; implicit reexport disabled  [attr-defined]
+ lib/tests/streamlit/bootstrap_test.py:26:1: error: Module "streamlit" does not explicitly export attribute "SECRETS_FILE_LOC"; implicit reexport disabled  [attr-defined]

@hauntsaninja hauntsaninja merged commit b633ae1 into python:master May 22, 2021
@dixith dixith deleted the double-quote-errors-3 branch May 22, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants