Skip to content

[mypyc] Emit native_int instead of int64/int32 in IR test output #10446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 25, 2021
Merged

[mypyc] Emit native_int instead of int64/int32 in IR test output #10446

merged 6 commits into from
May 25, 2021

Conversation

TH3CHARLie
Copy link
Collaborator

@TH3CHARLie TH3CHARLie commented May 8, 2021 •
edited
Loading

relates mypyc/mypyc#776

This is a super quick workaround. So far the issue mostly (if not completely) occurs in c_pyssize_t so making this rtype emits native_int would solve the issue. As a result, the replace_native_int pass in IR test is now removed.

@TH3CHARLie TH3CHARLie marked this pull request as draft May 8, 2021 07:13
@TH3CHARLie TH3CHARLie requested a review from JukkaL May 8, 2021 08:05
@TH3CHARLie TH3CHARLie marked this pull request as ready for review May 8, 2021 08:05
@97littleleaf11
Copy link
Collaborator

lgtm

JukkaL
JukkaL approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Confusion between different integer types in tests has been a common pain point. This will reduce friction when writing new features and changing the generated IR significantly.

@JukkaL JukkaL merged commit 61c3462 into python:master May 25, 2021
@TH3CHARLie TH3CHARLie deleted the emit-native-int branch May 26, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TH3CHARLie @97littleleaf11 @JukkaL