Fix crash related to module-level __getattr__ in incremental mode #10430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `from_module_getattr` attribute of `Var` was not serialized, so subsequent runs didn't know about this being from `__getattr__` and tried to create a cross-ref to the definition which doesn't actually exist, resulting in a crash. Fixes #10429.
ilevkivskyi
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
from_module_getattrattribute ofVarwas not serialized, sosubsequent runs didn't know about this being from
__getattr__andtried to create a cross-ref to the definition which doesn't actually
exist, resulting in a crash.
Fixes #10429.