Skip to content

Use double quotes errors 'in async function, 'Cannot determine type of' and 'syntax error in type comment' #10282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2021

Conversation

dixith
Copy link
Contributor

@dixith dixith commented Apr 5, 2021

Description

This pull request fixes issue reported in #7445 for in async function, Cannot determine type of and syntax error in type comment error messages

Test Plan

Updated test cases for the message. New test cases not added.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

Diff from mypy_primer, showing the effect of this PR on open source code:

pip (https://github.com/pypa/pip.git)
- src/pip/_internal/cli/progress_bars.py:201: error: Cannot determine type of 'file' in base class 'WindowsMixin'
+ src/pip/_internal/cli/progress_bars.py:201: error: Cannot determine type of "file" in base class "WindowsMixin"
- src/pip/_internal/cli/progress_bars.py:201: error: Cannot determine type of 'hide_cursor' in base class 'WindowsMixin'
+ src/pip/_internal/cli/progress_bars.py:201: error: Cannot determine type of "hide_cursor" in base class "WindowsMixin"
- src/pip/_internal/cli/progress_bars.py:205: error: Cannot determine type of 'file' in base class 'WindowsMixin'
+ src/pip/_internal/cli/progress_bars.py:205: error: Cannot determine type of "file" in base class "WindowsMixin"
- src/pip/_internal/cli/progress_bars.py:205: error: Cannot determine type of 'hide_cursor' in base class 'WindowsMixin'
+ src/pip/_internal/cli/progress_bars.py:205: error: Cannot determine type of "hide_cursor" in base class "WindowsMixin"
- src/pip/_internal/cli/progress_bars.py:209: error: Cannot determine type of 'file' in base class 'WindowsMixin'
+ src/pip/_internal/cli/progress_bars.py:209: error: Cannot determine type of "file" in base class "WindowsMixin"
- src/pip/_internal/cli/progress_bars.py:209: error: Cannot determine type of 'hide_cursor' in base class 'WindowsMixin'
+ src/pip/_internal/cli/progress_bars.py:209: error: Cannot determine type of "hide_cursor" in base class "WindowsMixin"
- src/pip/_internal/cli/progress_bars.py:213: error: Cannot determine type of 'file' in base class 'WindowsMixin'
+ src/pip/_internal/cli/progress_bars.py:213: error: Cannot determine type of "file" in base class "WindowsMixin"
- src/pip/_internal/cli/progress_bars.py:213: error: Cannot determine type of 'hide_cursor' in base class 'WindowsMixin'
+ src/pip/_internal/cli/progress_bars.py:213: error: Cannot determine type of "hide_cursor" in base class "WindowsMixin"
- src/pip/_internal/cli/progress_bars.py:217: error: Cannot determine type of 'hide_cursor' in base class 'WindowsMixin'
+ src/pip/_internal/cli/progress_bars.py:217: error: Cannot determine type of "hide_cursor" in base class "WindowsMixin"

scipy (https://github.com/scipy/scipy.git)
- scipy/special/tests/test_orthogonal.py:354: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:354: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:355: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:355: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:358: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:358: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:406: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:406: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:407: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:407: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:410: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:410: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:430: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:430: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:431: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:431: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:434: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:434: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:439: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:439: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:440: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:440: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:441: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:441: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:441: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:441: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:486: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:486: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:487: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:487: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:490: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:490: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:530: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:530: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:531: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:531: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:534: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:534: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:548: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:548: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:549: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:549: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:552: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:552: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:571: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:571: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:572: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:572: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:575: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:575: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:588: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:588: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:589: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:589: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:592: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:592: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:605: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:605: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:606: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:606: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:609: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:609: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:623: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:623: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:624: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:624: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:627: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:627: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:641: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:641: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:642: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:642: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:645: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:645: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:660: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:660: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:661: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:661: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:664: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:664: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:679: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:679: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:680: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:680: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:683: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:683: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:698: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:698: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:699: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:699: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:702: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:702: error: Cannot determine type of "m"  [has-type]
- scipy/special/tests/test_orthogonal.py:735: error: Cannot determine type of 'y'  [has-type]
+ scipy/special/tests/test_orthogonal.py:735: error: Cannot determine type of "y"  [has-type]
- scipy/special/tests/test_orthogonal.py:736: error: Cannot determine type of 'v'  [has-type]
+ scipy/special/tests/test_orthogonal.py:736: error: Cannot determine type of "v"  [has-type]
- scipy/special/tests/test_orthogonal.py:739: error: Cannot determine type of 'm'  [has-type]
+ scipy/special/tests/test_orthogonal.py:739: error: Cannot determine type of "m"  [has-type]


sympy (https://github.com/sympy/sympy.git)
- sympy/matrices/expressions/matmul.py:19: error: Cannot determine type of 'kind' in base class 'MatrixExpr'
+ sympy/matrices/expressions/matmul.py:19: error: Cannot determine type of "kind" in base class "MatrixExpr"
- sympy/matrices/expressions/matadd.py:17: error: Cannot determine type of 'kind' in base class 'MatrixExpr'
+ sympy/matrices/expressions/matadd.py:17: error: Cannot determine type of "kind" in base class "MatrixExpr"


poetry (https://github.com/python-poetry/poetry.git)
- poetry/__init__.py:4: error: Cannot determine type of '__path__'
+ poetry/__init__.py:4: error: Cannot determine type of "__path__"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants