Fix mro invoking #10137 #10138
Merged
Fix mro invoking #10137 #10138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Would it be possible to write a unit test? |
gen-xu
force-pushed
the
gen-xu/type.mro-fix
branch
from
193741a to
7b990b6
Compare
Added unit test for |
JelleZijlstra
approved these changes
Feb 26, 2021
sthagen
added a commit
to sthagen/python-mypy
that referenced
this pull request
Feb 27, 2021
stubgen: fix invoking mro() (python#10138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10137
Changed
obj.mro()totype.mro(obj)so it properly invokes themrooftypewhenobjistypeTest Plan
After this change,
stubgencan properly generate pyi files for cython modules or native modules that include types inheriting the builtintype. Any package include such definition of class would be suitable for testing this.Added a unittest for
generate_c_type_stubas well.