Skip to content

Fix (some of ) #7445 #10053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 11, 2021
Merged

Fix (some of ) #7445 #10053

merged 5 commits into from
Feb 11, 2021

Conversation

PrasanthChettri
Copy link
Contributor

@PrasanthChettri PrasanthChettri commented Feb 9, 2021 •
edited
Loading

Description

Fixes some of #7445
Replaces instances where single quotes are used in messages with double quotes around the mpypy/messages.py
There are two to three messages that still use single quotes, that are heavily present throughout the test cases.

Test Plan

Updated test cases for these specific changes, no new test cases added, only modified

@PrasanthChettri
Fixed #7445
3f92cbe 
Changed single quotes to double quotes , Changed testcase to accomodate
the new changes
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

Diff from mypy_primer, showing the effect of this PR on open source code:

dragonchain (https://github.com/dragonchain/dragonchain.git)
- dragonchain/webserver/helpers_utest.py:259:9: error: Need type annotation for 'input_dict' (hint: "input_dict: Dict[<type>, <type>] = ...")
+ dragonchain/webserver/helpers_utest.py:259:9: error: Need type annotation for "input_dict" (hint: "input_dict: Dict[<type>, <type>] = ...")
- dragonchain/broadcast_processor/broadcast_processor_utest.py:60:22: error: Need type annotation for 'fake_claim'
+ dragonchain/broadcast_processor/broadcast_processor_utest.py:60:22: error: Need type annotation for "fake_claim"
- dragonchain/transaction_processor/level_2_actions_utest.py:104:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:104:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:117:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:117:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:178:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:178:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:188:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:188:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")

streamlit (https://github.com/streamlit/streamlit.git)
- lib/tests/streamlit/media_file_manager_test.py:115:9: error: Need type annotation for 'sample_coords' (hint: "sample_coords: Set[<type>] = ...")  [var-annotated]
+ lib/tests/streamlit/media_file_manager_test.py:115:9: error: Need type annotation for "sample_coords" (hint: "sample_coords: Set[<type>] = ...")  [var-annotated]
- lib/tests/streamlit/scriptrunner/script_runner_test.py:440:9: error: Need type annotation for 'events' (hint: "events: List[<type>] = ...")  [var-annotated]
+ lib/tests/streamlit/scriptrunner/script_runner_test.py:440:9: error: Need type annotation for "events" (hint: "events: List[<type>] = ...")  [var-annotated]


manticore (https://github.com/trailofbits/manticore.git)
- tests/wasm/json2mc.py:63: error: Need type annotation for 'modules' (hint: "modules: List[<type>] = ...")
+ tests/wasm/json2mc.py:63: error: Need type annotation for "modules" (hint: "modules: List[<type>] = ...")
- tests/auto_generators/make_tests.py:18: error: Need type annotation for 'op_count' (hint: "op_count: Dict[<type>, <type>] = ...")
+ tests/auto_generators/make_tests.py:18: error: Need type annotation for "op_count" (hint: "op_count: Dict[<type>, <type>] = ...")

sympy (https://github.com/sympy/sympy.git)
- sympy/core/numbers.py:2445: error: Need type annotation for 'free_symbols' (hint: "free_symbols: Set[<type>] = ...")
+ sympy/core/numbers.py:2445: error: Need type annotation for "free_symbols" (hint: "free_symbols: Set[<type>] = ...")
- sympy/stats/stochastic_process_types.py:1027: error: Need type annotation for 'non_tree_edge_values' (hint: "non_tree_edge_values: Set[<type>] = ...")
+ sympy/stats/stochastic_process_types.py:1027: error: Need type annotation for "non_tree_edge_values" (hint: "non_tree_edge_values: Set[<type>] = ...")


poetry (https://github.com/python-poetry/poetry.git)
- poetry/repositories/base_repository.py:13: error: Need type annotation for '_packages' (hint: "_packages: List[<type>] = ...")
+ poetry/repositories/base_repository.py:13: error: Need type annotation for "_packages" (hint: "_packages: List[<type>] = ...")
- poetry/console/io/inputs/run_argv_input.py:15: error: Need type annotation for '_parameter_options' (hint: "_parameter_options: List[<type>] = ...")
+ poetry/console/io/inputs/run_argv_input.py:15: error: Need type annotation for "_parameter_options" (hint: "_parameter_options: List[<type>] = ...")
- poetry/utils/setup_reader.py:21: error: Need type annotation for 'DEFAULT'
+ poetry/utils/setup_reader.py:21: error: Need type annotation for "DEFAULT"
- poetry/utils/setup_reader.py:96: error: Need type annotation for 'extras_require' (hint: "extras_require: Dict[<type>, <type>] = ...")
+ poetry/utils/setup_reader.py:96: error: Need type annotation for "extras_require" (hint: "extras_require: Dict[<type>, <type>] = ...")
- poetry/utils/setup_reader.py:196: error: Need type annotation for 'install_requires' (hint: "install_requires: List[<type>] = ...")
+ poetry/utils/setup_reader.py:196: error: Need type annotation for "install_requires" (hint: "install_requires: List[<type>] = ...")
- poetry/utils/setup_reader.py:238: error: Need type annotation for 'extras_require' (hint: "extras_require: Dict[<type>, <type>] = ...")
+ poetry/utils/setup_reader.py:238: error: Need type annotation for "extras_require" (hint: "extras_require: Dict[<type>, <type>] = ...")
- poetry/installation/noop_installer.py:13: error: Need type annotation for '_installs' (hint: "_installs: List[<type>] = ...")
+ poetry/installation/noop_installer.py:13: error: Need type annotation for "_installs" (hint: "_installs: List[<type>] = ...")
- poetry/installation/noop_installer.py:14: error: Need type annotation for '_updates' (hint: "_updates: List[<type>] = ...")
+ poetry/installation/noop_installer.py:14: error: Need type annotation for "_updates" (hint: "_updates: List[<type>] = ...")
- poetry/installation/noop_installer.py:15: error: Need type annotation for '_removals' (hint: "_removals: List[<type>] = ...")
+ poetry/installation/noop_installer.py:15: error: Need type annotation for "_removals" (hint: "_removals: List[<type>] = ...")
- poetry/config/dict_config_source.py:9: error: Need type annotation for '_config' (hint: "_config: Dict[<type>, <type>] = ...")
+ poetry/config/dict_config_source.py:9: error: Need type annotation for "_config" (hint: "_config: Dict[<type>, <type>] = ...")
- poetry/mixology/failure.py:121: error: Need type annotation for 'details_for_cause' (hint: "details_for_cause: Dict[<type>, <type>] = ...")
+ poetry/mixology/failure.py:121: error: Need type annotation for "details_for_cause" (hint: "details_for_cause: Dict[<type>, <type>] = ...")
- poetry/utils/extras.py:25: note: 'list' is missing following 'Iterator' protocol member:
+ poetry/utils/extras.py:25: note: "list" is missing following "Iterator" protocol member:
- poetry/installation/authenticator.py:32: error: Need type annotation for '_credentials' (hint: "_credentials: Dict[<type>, <type>] = ...")
+ poetry/installation/authenticator.py:32: error: Need type annotation for "_credentials" (hint: "_credentials: Dict[<type>, <type>] = ...")
- poetry/packages/locker.py:294: error: Need type annotation for 'packages_by_name' (hint: "packages_by_name: Dict[<type>, <type>] = ...")
+ poetry/packages/locker.py:294: error: Need type annotation for "packages_by_name" (hint: "packages_by_name: Dict[<type>, <type>] = ...")
- poetry/packages/locker.py:511: error: Need type annotation for 'dependencies' (hint: "dependencies: Dict[<type>, <type>] = ...")
+ poetry/packages/locker.py:511: error: Need type annotation for "dependencies" (hint: "dependencies: Dict[<type>, <type>] = ...")
- poetry/utils/env.py:1392: error: Need type annotation for 'executed' (hint: "executed: List[<type>] = ...")
+ poetry/utils/env.py:1392: error: Need type annotation for "executed" (hint: "executed: List[<type>] = ...")
- poetry/puzzle/provider.py:67: error: Need type annotation for '_search_for' (hint: "_search_for: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:67: error: Need type annotation for "_search_for" (hint: "_search_for: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:70: error: Need type annotation for '_overrides' (hint: "_overrides: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:70: error: Need type annotation for "_overrides" (hint: "_overrides: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:71: error: Need type annotation for '_deferred_cache' (hint: "_deferred_cache: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:71: error: Need type annotation for "_deferred_cache" (hint: "_deferred_cache: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:537: error: Need type annotation for 'duplicates' (hint: "duplicates: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:537: error: Need type annotation for "duplicates" (hint: "duplicates: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:553: error: Need type annotation for 'by_constraint' (hint: "by_constraint: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:553: error: Need type annotation for "by_constraint" (hint: "by_constraint: Dict[<type>, <type>] = ...")
- poetry/publishing/uploader.py:227: error: Trying to read deleted variable 'e'
+ poetry/publishing/uploader.py:227: error: Trying to read deleted variable "e"
- poetry/installation/executor.py:83: error: Need type annotation for '_sections' (hint: "_sections: Dict[<type>, <type>] = ...")
+ poetry/installation/executor.py:83: error: Need type annotation for "_sections" (hint: "_sections: Dict[<type>, <type>] = ...")
- poetry/puzzle/solver.py:63: error: Need type annotation for '_overrides' (hint: "_overrides: List[<type>] = ...")
+ poetry/puzzle/solver.py:63: error: Need type annotation for "_overrides" (hint: "_overrides: List[<type>] = ...")
- poetry/puzzle/solver.py:321: error: Need type annotation for 'back_edges'
+ poetry/puzzle/solver.py:321: error: Need type annotation for "back_edges"
- poetry/puzzle/solver.py:322: error: Need type annotation for 'visited' (hint: "visited: Dict[<type>, <type>] = ...")
+ poetry/puzzle/solver.py:322: error: Need type annotation for "visited" (hint: "visited: Dict[<type>, <type>] = ...")
- poetry/puzzle/solver.py:323: error: Need type annotation for 'topo_sorted_nodes' (hint: "topo_sorted_nodes: List[<type>] = ...")
+ poetry/puzzle/solver.py:323: error: Need type annotation for "topo_sorted_nodes" (hint: "topo_sorted_nodes: List[<type>] = ...")
- poetry/installation/installer.py:62: error: Need type annotation for '_whitelist' (hint: "_whitelist: List[<type>] = ...")
+ poetry/installation/installer.py:62: error: Need type annotation for "_whitelist" (hint: "_whitelist: List[<type>] = ...")
- poetry/installation/installer.py:64: error: Need type annotation for '_extras' (hint: "_extras: List[<type>] = ...")
+ poetry/installation/installer.py:64: error: Need type annotation for "_extras" (hint: "_extras: List[<type>] = ...")
- poetry/console/commands/command.py:12: error: Need type annotation for 'loggers' (hint: "loggers: List[<type>] = ...")
+ poetry/console/commands/command.py:12: error: Need type annotation for "loggers" (hint: "loggers: List[<type>] = ...")

isort (https://github.com/pycqa/isort.git)
- isort/_vendored/toml/decoder.py:180: error: Need type annotation for 'implicitgroups' (hint: "implicitgroups: List[<type>] = ...")
+ isort/_vendored/toml/decoder.py:180: error: Need type annotation for "implicitgroups" (hint: "implicitgroups: List[<type>] = ...")

pytest (https://github.com/pytest-dev/pytest.git)
- src/_pytest/deprecated.py:25: error: Need type annotation for 'FILLFUNCARGS'  [var-annotated]
+ src/_pytest/deprecated.py:25: error: Need type annotation for "FILLFUNCARGS"  [var-annotated]
- src/_pytest/deprecated.py:31: error: Need type annotation for 'PYTEST_COLLECT_MODULE'  [var-annotated]
+ src/_pytest/deprecated.py:31: error: Need type annotation for "PYTEST_COLLECT_MODULE"  [var-annotated]
- src/_pytest/deprecated.py:76: error: Need type annotation for 'ARGUMENT_TYPE_STR_CHOICE'  [var-annotated]
+ src/_pytest/deprecated.py:76: error: Need type annotation for "ARGUMENT_TYPE_STR_CHOICE"  [var-annotated]
- src/_pytest/deprecated.py:84: error: Need type annotation for 'ARGUMENT_TYPE_STR'  [var-annotated]
+ src/_pytest/deprecated.py:84: error: Need type annotation for "ARGUMENT_TYPE_STR"  [var-annotated]
- src/_pytest/config/__init__.py:147: error: Need type annotation for 'exc_info'  [var-annotated]
+ src/_pytest/config/__init__.py:147: error: Need type annotation for "exc_info"  [var-annotated]
- src/_pytest/config/__init__.py:147: error: Need type annotation for 'exc_info'  [var-annotated]
+ src/_pytest/config/__init__.py:147: error: Need type annotation for "exc_info"  [var-annotated]
- src/_pytest/unittest.py:212: error: Need type annotation for 'excinfo'  [var-annotated]
+ src/_pytest/unittest.py:212: error: Need type annotation for "excinfo"  [var-annotated]
- src/_pytest/doctest.py:368: error: Need type annotation for 'inner_excinfo'  [var-annotated]
+ src/_pytest/doctest.py:368: error: Need type annotation for "inner_excinfo"  [var-annotated]

alerta (https://github.com/alerta/alerta.git)
- alerta/settings.py:72: error: Need type annotation for 'DELETE_SCOPES' (hint: "DELETE_SCOPES: List[<type>] = ...")
+ alerta/settings.py:72: error: Need type annotation for "DELETE_SCOPES" (hint: "DELETE_SCOPES: List[<type>] = ...")
- alerta/settings.py:109: error: Need type annotation for 'LDAP_DOMAINS' (hint: "LDAP_DOMAINS: Dict[<type>, <type>] = ...")
+ alerta/settings.py:109: error: Need type annotation for "LDAP_DOMAINS" (hint: "LDAP_DOMAINS: Dict[<type>, <type>] = ...")

freundTech
freundTech suggested changes Feb 9, 2021
View reviewed changes
mypy/messages.py Outdated
@@ -1280,14 +1280,14 @@ def redundant_left_operand(self, op_name: str, context: Context) -> None:
it does not change the truth value of the entire condition as a whole.
'op_name' should either be the string "and" or the string "or".
"""
self.redundant_expr("Left operand of '{}'".format(op_name), op_name == 'and', context)
self.redundant_expr("Left operand of \" {}\"".format(op_name), op_name == 'and', context)

This comment was marked as resolved.

Sign in to view

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

test-data/unit/check-functions.test Outdated
@@ -2344,7 +2344,7 @@ def make_list() -> List[T]: pass

l: List[int] = make_list()

bad = make_list() # E: Need type annotation for 'bad' (hint: "bad: List[<type>] = ...")
bad = make_list() # E: Need type annotation for "Bad" (hint: "bad: List[<type>] = ...")

This comment was marked as resolved.

Sign in to view

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

docs/source/getting_started.rst Outdated
@@ -302,7 +302,7 @@ for example, when assigning an empty dictionary to some global value:

.. code-block:: python

my_global_dict = {} # Error: Need type annotation for 'my_global_dict'
my_global_dict = {} # Error: "my_global_dict"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally deleted some text here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please restore

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

Diff from mypy_primer, showing the effect of this PR on open source code:

dragonchain (https://github.com/dragonchain/dragonchain.git)
- dragonchain/webserver/helpers_utest.py:259:9: error: Need type annotation for 'input_dict' (hint: "input_dict: Dict[<type>, <type>] = ...")
+ dragonchain/webserver/helpers_utest.py:259:9: error: Need type annotation for "input_dict" (hint: "input_dict: Dict[<type>, <type>] = ...")
- dragonchain/broadcast_processor/broadcast_processor_utest.py:60:22: error: Need type annotation for 'fake_claim'
+ dragonchain/broadcast_processor/broadcast_processor_utest.py:60:22: error: Need type annotation for "fake_claim"
- dragonchain/transaction_processor/level_2_actions_utest.py:104:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:104:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:117:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:117:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:178:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:178:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:188:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:188:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")

streamlit (https://github.com/streamlit/streamlit.git)
- lib/tests/streamlit/media_file_manager_test.py:115:9: error: Need type annotation for 'sample_coords' (hint: "sample_coords: Set[<type>] = ...")  [var-annotated]
+ lib/tests/streamlit/media_file_manager_test.py:115:9: error: Need type annotation for "sample_coords" (hint: "sample_coords: Set[<type>] = ...")  [var-annotated]
- lib/tests/streamlit/scriptrunner/script_runner_test.py:440:9: error: Need type annotation for 'events' (hint: "events: List[<type>] = ...")  [var-annotated]
+ lib/tests/streamlit/scriptrunner/script_runner_test.py:440:9: error: Need type annotation for "events" (hint: "events: List[<type>] = ...")  [var-annotated]


manticore (https://github.com/trailofbits/manticore.git)
- tests/wasm/json2mc.py:63: error: Need type annotation for 'modules' (hint: "modules: List[<type>] = ...")
+ tests/wasm/json2mc.py:63: error: Need type annotation for "modules" (hint: "modules: List[<type>] = ...")
- tests/auto_generators/make_tests.py:18: error: Need type annotation for 'op_count' (hint: "op_count: Dict[<type>, <type>] = ...")
+ tests/auto_generators/make_tests.py:18: error: Need type annotation for "op_count" (hint: "op_count: Dict[<type>, <type>] = ...")

sympy (https://github.com/sympy/sympy.git)
- sympy/core/numbers.py:2445: error: Need type annotation for 'free_symbols' (hint: "free_symbols: Set[<type>] = ...")
+ sympy/core/numbers.py:2445: error: Need type annotation for "free_symbols" (hint: "free_symbols: Set[<type>] = ...")
- sympy/stats/stochastic_process_types.py:1027: error: Need type annotation for 'non_tree_edge_values' (hint: "non_tree_edge_values: Set[<type>] = ...")
+ sympy/stats/stochastic_process_types.py:1027: error: Need type annotation for "non_tree_edge_values" (hint: "non_tree_edge_values: Set[<type>] = ...")


poetry (https://github.com/python-poetry/poetry.git)
- poetry/repositories/base_repository.py:13: error: Need type annotation for '_packages' (hint: "_packages: List[<type>] = ...")
+ poetry/repositories/base_repository.py:13: error: Need type annotation for "_packages" (hint: "_packages: List[<type>] = ...")
- poetry/console/io/inputs/run_argv_input.py:15: error: Need type annotation for '_parameter_options' (hint: "_parameter_options: List[<type>] = ...")
+ poetry/console/io/inputs/run_argv_input.py:15: error: Need type annotation for "_parameter_options" (hint: "_parameter_options: List[<type>] = ...")
- poetry/utils/setup_reader.py:21: error: Need type annotation for 'DEFAULT'
+ poetry/utils/setup_reader.py:21: error: Need type annotation for "DEFAULT"
- poetry/utils/setup_reader.py:96: error: Need type annotation for 'extras_require' (hint: "extras_require: Dict[<type>, <type>] = ...")
+ poetry/utils/setup_reader.py:96: error: Need type annotation for "extras_require" (hint: "extras_require: Dict[<type>, <type>] = ...")
- poetry/utils/setup_reader.py:196: error: Need type annotation for 'install_requires' (hint: "install_requires: List[<type>] = ...")
+ poetry/utils/setup_reader.py:196: error: Need type annotation for "install_requires" (hint: "install_requires: List[<type>] = ...")
- poetry/utils/setup_reader.py:238: error: Need type annotation for 'extras_require' (hint: "extras_require: Dict[<type>, <type>] = ...")
+ poetry/utils/setup_reader.py:238: error: Need type annotation for "extras_require" (hint: "extras_require: Dict[<type>, <type>] = ...")
- poetry/installation/noop_installer.py:13: error: Need type annotation for '_installs' (hint: "_installs: List[<type>] = ...")
+ poetry/installation/noop_installer.py:13: error: Need type annotation for "_installs" (hint: "_installs: List[<type>] = ...")
- poetry/installation/noop_installer.py:14: error: Need type annotation for '_updates' (hint: "_updates: List[<type>] = ...")
+ poetry/installation/noop_installer.py:14: error: Need type annotation for "_updates" (hint: "_updates: List[<type>] = ...")
- poetry/installation/noop_installer.py:15: error: Need type annotation for '_removals' (hint: "_removals: List[<type>] = ...")
+ poetry/installation/noop_installer.py:15: error: Need type annotation for "_removals" (hint: "_removals: List[<type>] = ...")
- poetry/config/dict_config_source.py:9: error: Need type annotation for '_config' (hint: "_config: Dict[<type>, <type>] = ...")
+ poetry/config/dict_config_source.py:9: error: Need type annotation for "_config" (hint: "_config: Dict[<type>, <type>] = ...")
- poetry/mixology/failure.py:121: error: Need type annotation for 'details_for_cause' (hint: "details_for_cause: Dict[<type>, <type>] = ...")
+ poetry/mixology/failure.py:121: error: Need type annotation for "details_for_cause" (hint: "details_for_cause: Dict[<type>, <type>] = ...")
- poetry/utils/extras.py:25: note: 'list' is missing following 'Iterator' protocol member:
+ poetry/utils/extras.py:25: note: "list" is missing following "Iterator" protocol member:
- poetry/installation/authenticator.py:32: error: Need type annotation for '_credentials' (hint: "_credentials: Dict[<type>, <type>] = ...")
+ poetry/installation/authenticator.py:32: error: Need type annotation for "_credentials" (hint: "_credentials: Dict[<type>, <type>] = ...")
- poetry/packages/locker.py:294: error: Need type annotation for 'packages_by_name' (hint: "packages_by_name: Dict[<type>, <type>] = ...")
+ poetry/packages/locker.py:294: error: Need type annotation for "packages_by_name" (hint: "packages_by_name: Dict[<type>, <type>] = ...")
- poetry/packages/locker.py:511: error: Need type annotation for 'dependencies' (hint: "dependencies: Dict[<type>, <type>] = ...")
+ poetry/packages/locker.py:511: error: Need type annotation for "dependencies" (hint: "dependencies: Dict[<type>, <type>] = ...")
- poetry/utils/env.py:1392: error: Need type annotation for 'executed' (hint: "executed: List[<type>] = ...")
+ poetry/utils/env.py:1392: error: Need type annotation for "executed" (hint: "executed: List[<type>] = ...")
- poetry/puzzle/provider.py:67: error: Need type annotation for '_search_for' (hint: "_search_for: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:67: error: Need type annotation for "_search_for" (hint: "_search_for: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:70: error: Need type annotation for '_overrides' (hint: "_overrides: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:70: error: Need type annotation for "_overrides" (hint: "_overrides: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:71: error: Need type annotation for '_deferred_cache' (hint: "_deferred_cache: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:71: error: Need type annotation for "_deferred_cache" (hint: "_deferred_cache: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:537: error: Need type annotation for 'duplicates' (hint: "duplicates: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:537: error: Need type annotation for "duplicates" (hint: "duplicates: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:553: error: Need type annotation for 'by_constraint' (hint: "by_constraint: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:553: error: Need type annotation for "by_constraint" (hint: "by_constraint: Dict[<type>, <type>] = ...")
- poetry/publishing/uploader.py:227: error: Trying to read deleted variable 'e'
+ poetry/publishing/uploader.py:227: error: Trying to read deleted variable "e"
- poetry/installation/executor.py:83: error: Need type annotation for '_sections' (hint: "_sections: Dict[<type>, <type>] = ...")
+ poetry/installation/executor.py:83: error: Need type annotation for "_sections" (hint: "_sections: Dict[<type>, <type>] = ...")
- poetry/puzzle/solver.py:63: error: Need type annotation for '_overrides' (hint: "_overrides: List[<type>] = ...")
+ poetry/puzzle/solver.py:63: error: Need type annotation for "_overrides" (hint: "_overrides: List[<type>] = ...")
- poetry/puzzle/solver.py:321: error: Need type annotation for 'back_edges'
+ poetry/puzzle/solver.py:321: error: Need type annotation for "back_edges"
- poetry/puzzle/solver.py:322: error: Need type annotation for 'visited' (hint: "visited: Dict[<type>, <type>] = ...")
+ poetry/puzzle/solver.py:322: error: Need type annotation for "visited" (hint: "visited: Dict[<type>, <type>] = ...")
- poetry/puzzle/solver.py:323: error: Need type annotation for 'topo_sorted_nodes' (hint: "topo_sorted_nodes: List[<type>] = ...")
+ poetry/puzzle/solver.py:323: error: Need type annotation for "topo_sorted_nodes" (hint: "topo_sorted_nodes: List[<type>] = ...")
- poetry/installation/installer.py:62: error: Need type annotation for '_whitelist' (hint: "_whitelist: List[<type>] = ...")
+ poetry/installation/installer.py:62: error: Need type annotation for "_whitelist" (hint: "_whitelist: List[<type>] = ...")
- poetry/installation/installer.py:64: error: Need type annotation for '_extras' (hint: "_extras: List[<type>] = ...")
+ poetry/installation/installer.py:64: error: Need type annotation for "_extras" (hint: "_extras: List[<type>] = ...")
- poetry/console/commands/command.py:12: error: Need type annotation for 'loggers' (hint: "loggers: List[<type>] = ...")
+ poetry/console/commands/command.py:12: error: Need type annotation for "loggers" (hint: "loggers: List[<type>] = ...")

isort (https://github.com/pycqa/isort.git)
- isort/_vendored/toml/decoder.py:180: error: Need type annotation for 'implicitgroups' (hint: "implicitgroups: List[<type>] = ...")
+ isort/_vendored/toml/decoder.py:180: error: Need type annotation for "implicitgroups" (hint: "implicitgroups: List[<type>] = ...")

alerta (https://github.com/alerta/alerta.git)
- alerta/settings.py:72: error: Need type annotation for 'DELETE_SCOPES' (hint: "DELETE_SCOPES: List[<type>] = ...")
+ alerta/settings.py:72: error: Need type annotation for "DELETE_SCOPES" (hint: "DELETE_SCOPES: List[<type>] = ...")
- alerta/settings.py:109: error: Need type annotation for 'LDAP_DOMAINS' (hint: "LDAP_DOMAINS: Dict[<type>, <type>] = ...")
+ alerta/settings.py:109: error: Need type annotation for "LDAP_DOMAINS" (hint: "LDAP_DOMAINS: Dict[<type>, <type>] = ...")

pytest (https://github.com/pytest-dev/pytest.git)
- src/_pytest/deprecated.py:25: error: Need type annotation for 'FILLFUNCARGS'  [var-annotated]
+ src/_pytest/deprecated.py:25: error: Need type annotation for "FILLFUNCARGS"  [var-annotated]
- src/_pytest/deprecated.py:31: error: Need type annotation for 'PYTEST_COLLECT_MODULE'  [var-annotated]
+ src/_pytest/deprecated.py:31: error: Need type annotation for "PYTEST_COLLECT_MODULE"  [var-annotated]
- src/_pytest/deprecated.py:76: error: Need type annotation for 'ARGUMENT_TYPE_STR_CHOICE'  [var-annotated]
+ src/_pytest/deprecated.py:76: error: Need type annotation for "ARGUMENT_TYPE_STR_CHOICE"  [var-annotated]
- src/_pytest/deprecated.py:84: error: Need type annotation for 'ARGUMENT_TYPE_STR'  [var-annotated]
+ src/_pytest/deprecated.py:84: error: Need type annotation for "ARGUMENT_TYPE_STR"  [var-annotated]
- src/_pytest/config/__init__.py:147: error: Need type annotation for 'exc_info'  [var-annotated]
+ src/_pytest/config/__init__.py:147: error: Need type annotation for "exc_info"  [var-annotated]
- src/_pytest/config/__init__.py:147: error: Need type annotation for 'exc_info'  [var-annotated]
+ src/_pytest/config/__init__.py:147: error: Need type annotation for "exc_info"  [var-annotated]
- src/_pytest/unittest.py:212: error: Need type annotation for 'excinfo'  [var-annotated]
+ src/_pytest/unittest.py:212: error: Need type annotation for "excinfo"  [var-annotated]
- src/_pytest/doctest.py:368: error: Need type annotation for 'inner_excinfo'  [var-annotated]
+ src/_pytest/doctest.py:368: error: Need type annotation for "inner_excinfo"  [var-annotated]

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

Diff from mypy_primer, showing the effect of this PR on open source code:

dragonchain (https://github.com/dragonchain/dragonchain.git)
- dragonchain/webserver/helpers_utest.py:259:9: error: Need type annotation for 'input_dict' (hint: "input_dict: Dict[<type>, <type>] = ...")
+ dragonchain/webserver/helpers_utest.py:259:9: error: Need type annotation for "input_dict" (hint: "input_dict: Dict[<type>, <type>] = ...")
- dragonchain/broadcast_processor/broadcast_processor_utest.py:60:22: error: Need type annotation for 'fake_claim'
+ dragonchain/broadcast_processor/broadcast_processor_utest.py:60:22: error: Need type annotation for "fake_claim"
- dragonchain/transaction_processor/level_2_actions_utest.py:104:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:104:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:117:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:117:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:178:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:178:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:188:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:188:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")

streamlit (https://github.com/streamlit/streamlit.git)
- lib/tests/streamlit/media_file_manager_test.py:115:9: error: Need type annotation for 'sample_coords' (hint: "sample_coords: Set[<type>] = ...")  [var-annotated]
+ lib/tests/streamlit/media_file_manager_test.py:115:9: error: Need type annotation for "sample_coords" (hint: "sample_coords: Set[<type>] = ...")  [var-annotated]
- lib/tests/streamlit/scriptrunner/script_runner_test.py:440:9: error: Need type annotation for 'events' (hint: "events: List[<type>] = ...")  [var-annotated]
+ lib/tests/streamlit/scriptrunner/script_runner_test.py:440:9: error: Need type annotation for "events" (hint: "events: List[<type>] = ...")  [var-annotated]


manticore (https://github.com/trailofbits/manticore.git)
- tests/wasm/json2mc.py:63: error: Need type annotation for 'modules' (hint: "modules: List[<type>] = ...")
+ tests/wasm/json2mc.py:63: error: Need type annotation for "modules" (hint: "modules: List[<type>] = ...")
- tests/auto_generators/make_tests.py:18: error: Need type annotation for 'op_count' (hint: "op_count: Dict[<type>, <type>] = ...")
+ tests/auto_generators/make_tests.py:18: error: Need type annotation for "op_count" (hint: "op_count: Dict[<type>, <type>] = ...")

sympy (https://github.com/sympy/sympy.git)
- sympy/core/numbers.py:2445: error: Need type annotation for 'free_symbols' (hint: "free_symbols: Set[<type>] = ...")
+ sympy/core/numbers.py:2445: error: Need type annotation for "free_symbols" (hint: "free_symbols: Set[<type>] = ...")
- sympy/stats/stochastic_process_types.py:1027: error: Need type annotation for 'non_tree_edge_values' (hint: "non_tree_edge_values: Set[<type>] = ...")
+ sympy/stats/stochastic_process_types.py:1027: error: Need type annotation for "non_tree_edge_values" (hint: "non_tree_edge_values: Set[<type>] = ...")


poetry (https://github.com/python-poetry/poetry.git)
- poetry/repositories/base_repository.py:13: error: Need type annotation for '_packages' (hint: "_packages: List[<type>] = ...")
+ poetry/repositories/base_repository.py:13: error: Need type annotation for "_packages" (hint: "_packages: List[<type>] = ...")
- poetry/console/io/inputs/run_argv_input.py:15: error: Need type annotation for '_parameter_options' (hint: "_parameter_options: List[<type>] = ...")
+ poetry/console/io/inputs/run_argv_input.py:15: error: Need type annotation for "_parameter_options" (hint: "_parameter_options: List[<type>] = ...")
- poetry/utils/setup_reader.py:21: error: Need type annotation for 'DEFAULT'
+ poetry/utils/setup_reader.py:21: error: Need type annotation for "DEFAULT"
- poetry/utils/setup_reader.py:96: error: Need type annotation for 'extras_require' (hint: "extras_require: Dict[<type>, <type>] = ...")
+ poetry/utils/setup_reader.py:96: error: Need type annotation for "extras_require" (hint: "extras_require: Dict[<type>, <type>] = ...")
- poetry/utils/setup_reader.py:196: error: Need type annotation for 'install_requires' (hint: "install_requires: List[<type>] = ...")
+ poetry/utils/setup_reader.py:196: error: Need type annotation for "install_requires" (hint: "install_requires: List[<type>] = ...")
- poetry/utils/setup_reader.py:238: error: Need type annotation for 'extras_require' (hint: "extras_require: Dict[<type>, <type>] = ...")
+ poetry/utils/setup_reader.py:238: error: Need type annotation for "extras_require" (hint: "extras_require: Dict[<type>, <type>] = ...")
- poetry/installation/noop_installer.py:13: error: Need type annotation for '_installs' (hint: "_installs: List[<type>] = ...")
+ poetry/installation/noop_installer.py:13: error: Need type annotation for "_installs" (hint: "_installs: List[<type>] = ...")
- poetry/installation/noop_installer.py:14: error: Need type annotation for '_updates' (hint: "_updates: List[<type>] = ...")
+ poetry/installation/noop_installer.py:14: error: Need type annotation for "_updates" (hint: "_updates: List[<type>] = ...")
- poetry/installation/noop_installer.py:15: error: Need type annotation for '_removals' (hint: "_removals: List[<type>] = ...")
+ poetry/installation/noop_installer.py:15: error: Need type annotation for "_removals" (hint: "_removals: List[<type>] = ...")
- poetry/config/dict_config_source.py:9: error: Need type annotation for '_config' (hint: "_config: Dict[<type>, <type>] = ...")
+ poetry/config/dict_config_source.py:9: error: Need type annotation for "_config" (hint: "_config: Dict[<type>, <type>] = ...")
- poetry/mixology/failure.py:121: error: Need type annotation for 'details_for_cause' (hint: "details_for_cause: Dict[<type>, <type>] = ...")
+ poetry/mixology/failure.py:121: error: Need type annotation for "details_for_cause" (hint: "details_for_cause: Dict[<type>, <type>] = ...")
- poetry/utils/extras.py:25: note: 'list' is missing following 'Iterator' protocol member:
+ poetry/utils/extras.py:25: note: "list" is missing following "Iterator" protocol member:
- poetry/installation/authenticator.py:32: error: Need type annotation for '_credentials' (hint: "_credentials: Dict[<type>, <type>] = ...")
+ poetry/installation/authenticator.py:32: error: Need type annotation for "_credentials" (hint: "_credentials: Dict[<type>, <type>] = ...")
- poetry/packages/locker.py:294: error: Need type annotation for 'packages_by_name' (hint: "packages_by_name: Dict[<type>, <type>] = ...")
+ poetry/packages/locker.py:294: error: Need type annotation for "packages_by_name" (hint: "packages_by_name: Dict[<type>, <type>] = ...")
- poetry/packages/locker.py:511: error: Need type annotation for 'dependencies' (hint: "dependencies: Dict[<type>, <type>] = ...")
+ poetry/packages/locker.py:511: error: Need type annotation for "dependencies" (hint: "dependencies: Dict[<type>, <type>] = ...")
- poetry/utils/env.py:1392: error: Need type annotation for 'executed' (hint: "executed: List[<type>] = ...")
+ poetry/utils/env.py:1392: error: Need type annotation for "executed" (hint: "executed: List[<type>] = ...")
- poetry/puzzle/provider.py:67: error: Need type annotation for '_search_for' (hint: "_search_for: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:67: error: Need type annotation for "_search_for" (hint: "_search_for: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:70: error: Need type annotation for '_overrides' (hint: "_overrides: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:70: error: Need type annotation for "_overrides" (hint: "_overrides: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:71: error: Need type annotation for '_deferred_cache' (hint: "_deferred_cache: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:71: error: Need type annotation for "_deferred_cache" (hint: "_deferred_cache: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:537: error: Need type annotation for 'duplicates' (hint: "duplicates: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:537: error: Need type annotation for "duplicates" (hint: "duplicates: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:553: error: Need type annotation for 'by_constraint' (hint: "by_constraint: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:553: error: Need type annotation for "by_constraint" (hint: "by_constraint: Dict[<type>, <type>] = ...")
- poetry/publishing/uploader.py:227: error: Trying to read deleted variable 'e'
+ poetry/publishing/uploader.py:227: error: Trying to read deleted variable "e"
- poetry/installation/executor.py:83: error: Need type annotation for '_sections' (hint: "_sections: Dict[<type>, <type>] = ...")
+ poetry/installation/executor.py:83: error: Need type annotation for "_sections" (hint: "_sections: Dict[<type>, <type>] = ...")
- poetry/puzzle/solver.py:63: error: Need type annotation for '_overrides' (hint: "_overrides: List[<type>] = ...")
+ poetry/puzzle/solver.py:63: error: Need type annotation for "_overrides" (hint: "_overrides: List[<type>] = ...")
- poetry/puzzle/solver.py:321: error: Need type annotation for 'back_edges'
+ poetry/puzzle/solver.py:321: error: Need type annotation for "back_edges"
- poetry/puzzle/solver.py:322: error: Need type annotation for 'visited' (hint: "visited: Dict[<type>, <type>] = ...")
+ poetry/puzzle/solver.py:322: error: Need type annotation for "visited" (hint: "visited: Dict[<type>, <type>] = ...")
- poetry/puzzle/solver.py:323: error: Need type annotation for 'topo_sorted_nodes' (hint: "topo_sorted_nodes: List[<type>] = ...")
+ poetry/puzzle/solver.py:323: error: Need type annotation for "topo_sorted_nodes" (hint: "topo_sorted_nodes: List[<type>] = ...")
- poetry/installation/installer.py:62: error: Need type annotation for '_whitelist' (hint: "_whitelist: List[<type>] = ...")
+ poetry/installation/installer.py:62: error: Need type annotation for "_whitelist" (hint: "_whitelist: List[<type>] = ...")
- poetry/installation/installer.py:64: error: Need type annotation for '_extras' (hint: "_extras: List[<type>] = ...")
+ poetry/installation/installer.py:64: error: Need type annotation for "_extras" (hint: "_extras: List[<type>] = ...")
- poetry/console/commands/command.py:12: error: Need type annotation for 'loggers' (hint: "loggers: List[<type>] = ...")
+ poetry/console/commands/command.py:12: error: Need type annotation for "loggers" (hint: "loggers: List[<type>] = ...")

pytest (https://github.com/pytest-dev/pytest.git)
- src/_pytest/deprecated.py:25: error: Need type annotation for 'FILLFUNCARGS'  [var-annotated]
+ src/_pytest/deprecated.py:25: error: Need type annotation for "FILLFUNCARGS"  [var-annotated]
- src/_pytest/deprecated.py:31: error: Need type annotation for 'PYTEST_COLLECT_MODULE'  [var-annotated]
+ src/_pytest/deprecated.py:31: error: Need type annotation for "PYTEST_COLLECT_MODULE"  [var-annotated]
- src/_pytest/deprecated.py:76: error: Need type annotation for 'ARGUMENT_TYPE_STR_CHOICE'  [var-annotated]
+ src/_pytest/deprecated.py:76: error: Need type annotation for "ARGUMENT_TYPE_STR_CHOICE"  [var-annotated]
- src/_pytest/deprecated.py:84: error: Need type annotation for 'ARGUMENT_TYPE_STR'  [var-annotated]
+ src/_pytest/deprecated.py:84: error: Need type annotation for "ARGUMENT_TYPE_STR"  [var-annotated]
- src/_pytest/config/__init__.py:147: error: Need type annotation for 'exc_info'  [var-annotated]
+ src/_pytest/config/__init__.py:147: error: Need type annotation for "exc_info"  [var-annotated]
- src/_pytest/config/__init__.py:147: error: Need type annotation for 'exc_info'  [var-annotated]
+ src/_pytest/config/__init__.py:147: error: Need type annotation for "exc_info"  [var-annotated]
- src/_pytest/unittest.py:212: error: Need type annotation for 'excinfo'  [var-annotated]
+ src/_pytest/unittest.py:212: error: Need type annotation for "excinfo"  [var-annotated]
- src/_pytest/doctest.py:368: error: Need type annotation for 'inner_excinfo'  [var-annotated]
+ src/_pytest/doctest.py:368: error: Need type annotation for "inner_excinfo"  [var-annotated]

isort (https://github.com/pycqa/isort.git)
- isort/_vendored/toml/decoder.py:180: error: Need type annotation for 'implicitgroups' (hint: "implicitgroups: List[<type>] = ...")
+ isort/_vendored/toml/decoder.py:180: error: Need type annotation for "implicitgroups" (hint: "implicitgroups: List[<type>] = ...")

alerta (https://github.com/alerta/alerta.git)
- alerta/settings.py:72: error: Need type annotation for 'DELETE_SCOPES' (hint: "DELETE_SCOPES: List[<type>] = ...")
+ alerta/settings.py:72: error: Need type annotation for "DELETE_SCOPES" (hint: "DELETE_SCOPES: List[<type>] = ...")
- alerta/settings.py:109: error: Need type annotation for 'LDAP_DOMAINS' (hint: "LDAP_DOMAINS: Dict[<type>, <type>] = ...")
+ alerta/settings.py:109: error: Need type annotation for "LDAP_DOMAINS" (hint: "LDAP_DOMAINS: Dict[<type>, <type>] = ...")

JelleZijlstra
JelleZijlstra requested changes Feb 9, 2021
View reviewed changes
docs/source/getting_started.rst Outdated
@@ -302,7 +302,7 @@ for example, when assigning an empty dictionary to some global value:

.. code-block:: python

my_global_dict = {} # Error: Need type annotation for 'my_global_dict'
my_global_dict = {} # Error: "my_global_dict"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please restore

@PrasanthChettri
Resolved the changes requested
bddcb13 
namely :
Aciddentally deleted stuff in the docs
Change the outer quotes to ' (single quotes) so you don't need the escaping
@PrasanthChettri
small typo in the changed documentation
5710866
@PrasanthChettri PrasanthChettri changed the title Fixed #7445 Fix #7445 Feb 10, 2021
@PrasanthChettri PrasanthChettri changed the title Fix #7445 Fix <u> some of </u> #7445 Feb 10, 2021
@PrasanthChettri PrasanthChettri changed the title Fix <u> some of </u> #7445 Fix (some of ) #7445 Feb 10, 2021
@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

dragonchain (https://github.com/dragonchain/dragonchain.git)
- dragonchain/webserver/helpers_utest.py:259:9: error: Need type annotation for 'input_dict' (hint: "input_dict: Dict[<type>, <type>] = ...")
+ dragonchain/webserver/helpers_utest.py:259:9: error: Need type annotation for "input_dict" (hint: "input_dict: Dict[<type>, <type>] = ...")
- dragonchain/broadcast_processor/broadcast_processor_utest.py:60:22: error: Need type annotation for 'fake_claim'
+ dragonchain/broadcast_processor/broadcast_processor_utest.py:60:22: error: Need type annotation for "fake_claim"
- dragonchain/transaction_processor/level_2_actions_utest.py:104:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:104:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:117:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:117:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:178:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:178:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")
- dragonchain/transaction_processor/level_2_actions_utest.py:188:9: error: Need type annotation for 'txn_map' (hint: "txn_map: Dict[<type>, <type>] = ...")
+ dragonchain/transaction_processor/level_2_actions_utest.py:188:9: error: Need type annotation for "txn_map" (hint: "txn_map: Dict[<type>, <type>] = ...")

streamlit (https://github.com/streamlit/streamlit.git)
- lib/tests/streamlit/media_file_manager_test.py:115:9: error: Need type annotation for 'sample_coords' (hint: "sample_coords: Set[<type>] = ...")  [var-annotated]
+ lib/tests/streamlit/media_file_manager_test.py:115:9: error: Need type annotation for "sample_coords" (hint: "sample_coords: Set[<type>] = ...")  [var-annotated]
- lib/tests/streamlit/scriptrunner/script_runner_test.py:440:9: error: Need type annotation for 'events' (hint: "events: List[<type>] = ...")  [var-annotated]
+ lib/tests/streamlit/scriptrunner/script_runner_test.py:440:9: error: Need type annotation for "events" (hint: "events: List[<type>] = ...")  [var-annotated]


manticore (https://github.com/trailofbits/manticore.git)
- tests/wasm/json2mc.py:63: error: Need type annotation for 'modules' (hint: "modules: List[<type>] = ...")
+ tests/wasm/json2mc.py:63: error: Need type annotation for "modules" (hint: "modules: List[<type>] = ...")
- tests/auto_generators/make_tests.py:18: error: Need type annotation for 'op_count' (hint: "op_count: Dict[<type>, <type>] = ...")
+ tests/auto_generators/make_tests.py:18: error: Need type annotation for "op_count" (hint: "op_count: Dict[<type>, <type>] = ...")

sympy (https://github.com/sympy/sympy.git)
- sympy/core/numbers.py:2445: error: Need type annotation for 'free_symbols' (hint: "free_symbols: Set[<type>] = ...")
+ sympy/core/numbers.py:2445: error: Need type annotation for "free_symbols" (hint: "free_symbols: Set[<type>] = ...")
- sympy/stats/stochastic_process_types.py:1027: error: Need type annotation for 'non_tree_edge_values' (hint: "non_tree_edge_values: Set[<type>] = ...")
+ sympy/stats/stochastic_process_types.py:1027: error: Need type annotation for "non_tree_edge_values" (hint: "non_tree_edge_values: Set[<type>] = ...")


pytest (https://github.com/pytest-dev/pytest.git)
- src/_pytest/deprecated.py:25: error: Need type annotation for 'FILLFUNCARGS'  [var-annotated]
+ src/_pytest/deprecated.py:25: error: Need type annotation for "FILLFUNCARGS"  [var-annotated]
- src/_pytest/deprecated.py:31: error: Need type annotation for 'PYTEST_COLLECT_MODULE'  [var-annotated]
+ src/_pytest/deprecated.py:31: error: Need type annotation for "PYTEST_COLLECT_MODULE"  [var-annotated]
- src/_pytest/deprecated.py:76: error: Need type annotation for 'ARGUMENT_TYPE_STR_CHOICE'  [var-annotated]
+ src/_pytest/deprecated.py:76: error: Need type annotation for "ARGUMENT_TYPE_STR_CHOICE"  [var-annotated]
- src/_pytest/deprecated.py:84: error: Need type annotation for 'ARGUMENT_TYPE_STR'  [var-annotated]
+ src/_pytest/deprecated.py:84: error: Need type annotation for "ARGUMENT_TYPE_STR"  [var-annotated]
- src/_pytest/config/__init__.py:147: error: Need type annotation for 'exc_info'  [var-annotated]
+ src/_pytest/config/__init__.py:147: error: Need type annotation for "exc_info"  [var-annotated]
- src/_pytest/config/__init__.py:147: error: Need type annotation for 'exc_info'  [var-annotated]
+ src/_pytest/config/__init__.py:147: error: Need type annotation for "exc_info"  [var-annotated]
- src/_pytest/unittest.py:212: error: Need type annotation for 'excinfo'  [var-annotated]
+ src/_pytest/unittest.py:212: error: Need type annotation for "excinfo"  [var-annotated]
- src/_pytest/doctest.py:368: error: Need type annotation for 'inner_excinfo'  [var-annotated]
+ src/_pytest/doctest.py:368: error: Need type annotation for "inner_excinfo"  [var-annotated]

alerta (https://github.com/alerta/alerta.git)
- alerta/settings.py:72: error: Need type annotation for 'DELETE_SCOPES' (hint: "DELETE_SCOPES: List[<type>] = ...")
+ alerta/settings.py:72: error: Need type annotation for "DELETE_SCOPES" (hint: "DELETE_SCOPES: List[<type>] = ...")
- alerta/settings.py:109: error: Need type annotation for 'LDAP_DOMAINS' (hint: "LDAP_DOMAINS: Dict[<type>, <type>] = ...")
+ alerta/settings.py:109: error: Need type annotation for "LDAP_DOMAINS" (hint: "LDAP_DOMAINS: Dict[<type>, <type>] = ...")

isort (https://github.com/pycqa/isort.git)
- isort/_vendored/toml/decoder.py:180: error: Need type annotation for 'implicitgroups' (hint: "implicitgroups: List[<type>] = ...")
+ isort/_vendored/toml/decoder.py:180: error: Need type annotation for "implicitgroups" (hint: "implicitgroups: List[<type>] = ...")

poetry (https://github.com/python-poetry/poetry.git)
- poetry/repositories/base_repository.py:13: error: Need type annotation for '_packages' (hint: "_packages: List[<type>] = ...")
+ poetry/repositories/base_repository.py:13: error: Need type annotation for "_packages" (hint: "_packages: List[<type>] = ...")
- poetry/console/io/inputs/run_argv_input.py:15: error: Need type annotation for '_parameter_options' (hint: "_parameter_options: List[<type>] = ...")
+ poetry/console/io/inputs/run_argv_input.py:15: error: Need type annotation for "_parameter_options" (hint: "_parameter_options: List[<type>] = ...")
- poetry/utils/setup_reader.py:21: error: Need type annotation for 'DEFAULT'
+ poetry/utils/setup_reader.py:21: error: Need type annotation for "DEFAULT"
- poetry/utils/setup_reader.py:96: error: Need type annotation for 'extras_require' (hint: "extras_require: Dict[<type>, <type>] = ...")
+ poetry/utils/setup_reader.py:96: error: Need type annotation for "extras_require" (hint: "extras_require: Dict[<type>, <type>] = ...")
- poetry/utils/setup_reader.py:196: error: Need type annotation for 'install_requires' (hint: "install_requires: List[<type>] = ...")
+ poetry/utils/setup_reader.py:196: error: Need type annotation for "install_requires" (hint: "install_requires: List[<type>] = ...")
- poetry/utils/setup_reader.py:238: error: Need type annotation for 'extras_require' (hint: "extras_require: Dict[<type>, <type>] = ...")
+ poetry/utils/setup_reader.py:238: error: Need type annotation for "extras_require" (hint: "extras_require: Dict[<type>, <type>] = ...")
- poetry/installation/noop_installer.py:13: error: Need type annotation for '_installs' (hint: "_installs: List[<type>] = ...")
+ poetry/installation/noop_installer.py:13: error: Need type annotation for "_installs" (hint: "_installs: List[<type>] = ...")
- poetry/installation/noop_installer.py:14: error: Need type annotation for '_updates' (hint: "_updates: List[<type>] = ...")
+ poetry/installation/noop_installer.py:14: error: Need type annotation for "_updates" (hint: "_updates: List[<type>] = ...")
- poetry/installation/noop_installer.py:15: error: Need type annotation for '_removals' (hint: "_removals: List[<type>] = ...")
+ poetry/installation/noop_installer.py:15: error: Need type annotation for "_removals" (hint: "_removals: List[<type>] = ...")
- poetry/config/dict_config_source.py:9: error: Need type annotation for '_config' (hint: "_config: Dict[<type>, <type>] = ...")
+ poetry/config/dict_config_source.py:9: error: Need type annotation for "_config" (hint: "_config: Dict[<type>, <type>] = ...")
- poetry/mixology/failure.py:121: error: Need type annotation for 'details_for_cause' (hint: "details_for_cause: Dict[<type>, <type>] = ...")
+ poetry/mixology/failure.py:121: error: Need type annotation for "details_for_cause" (hint: "details_for_cause: Dict[<type>, <type>] = ...")
- poetry/utils/extras.py:25: note: 'list' is missing following 'Iterator' protocol member:
+ poetry/utils/extras.py:25: note: "list" is missing following "Iterator" protocol member:
- poetry/installation/authenticator.py:32: error: Need type annotation for '_credentials' (hint: "_credentials: Dict[<type>, <type>] = ...")
+ poetry/installation/authenticator.py:32: error: Need type annotation for "_credentials" (hint: "_credentials: Dict[<type>, <type>] = ...")
- poetry/packages/locker.py:294: error: Need type annotation for 'packages_by_name' (hint: "packages_by_name: Dict[<type>, <type>] = ...")
+ poetry/packages/locker.py:294: error: Need type annotation for "packages_by_name" (hint: "packages_by_name: Dict[<type>, <type>] = ...")
- poetry/packages/locker.py:511: error: Need type annotation for 'dependencies' (hint: "dependencies: Dict[<type>, <type>] = ...")
+ poetry/packages/locker.py:511: error: Need type annotation for "dependencies" (hint: "dependencies: Dict[<type>, <type>] = ...")
- poetry/utils/env.py:1392: error: Need type annotation for 'executed' (hint: "executed: List[<type>] = ...")
+ poetry/utils/env.py:1392: error: Need type annotation for "executed" (hint: "executed: List[<type>] = ...")
- poetry/puzzle/provider.py:67: error: Need type annotation for '_search_for' (hint: "_search_for: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:67: error: Need type annotation for "_search_for" (hint: "_search_for: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:70: error: Need type annotation for '_overrides' (hint: "_overrides: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:70: error: Need type annotation for "_overrides" (hint: "_overrides: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:71: error: Need type annotation for '_deferred_cache' (hint: "_deferred_cache: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:71: error: Need type annotation for "_deferred_cache" (hint: "_deferred_cache: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:537: error: Need type annotation for 'duplicates' (hint: "duplicates: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:537: error: Need type annotation for "duplicates" (hint: "duplicates: Dict[<type>, <type>] = ...")
- poetry/puzzle/provider.py:553: error: Need type annotation for 'by_constraint' (hint: "by_constraint: Dict[<type>, <type>] = ...")
+ poetry/puzzle/provider.py:553: error: Need type annotation for "by_constraint" (hint: "by_constraint: Dict[<type>, <type>] = ...")
- poetry/publishing/uploader.py:227: error: Trying to read deleted variable 'e'
+ poetry/publishing/uploader.py:227: error: Trying to read deleted variable "e"
- poetry/installation/executor.py:83: error: Need type annotation for '_sections' (hint: "_sections: Dict[<type>, <type>] = ...")
+ poetry/installation/executor.py:83: error: Need type annotation for "_sections" (hint: "_sections: Dict[<type>, <type>] = ...")
- poetry/puzzle/solver.py:63: error: Need type annotation for '_overrides' (hint: "_overrides: List[<type>] = ...")
+ poetry/puzzle/solver.py:63: error: Need type annotation for "_overrides" (hint: "_overrides: List[<type>] = ...")
- poetry/puzzle/solver.py:321: error: Need type annotation for 'back_edges'
+ poetry/puzzle/solver.py:321: error: Need type annotation for "back_edges"
- poetry/puzzle/solver.py:322: error: Need type annotation for 'visited' (hint: "visited: Dict[<type>, <type>] = ...")
+ poetry/puzzle/solver.py:322: error: Need type annotation for "visited" (hint: "visited: Dict[<type>, <type>] = ...")
- poetry/puzzle/solver.py:323: error: Need type annotation for 'topo_sorted_nodes' (hint: "topo_sorted_nodes: List[<type>] = ...")
+ poetry/puzzle/solver.py:323: error: Need type annotation for "topo_sorted_nodes" (hint: "topo_sorted_nodes: List[<type>] = ...")
- poetry/installation/installer.py:62: error: Need type annotation for '_whitelist' (hint: "_whitelist: List[<type>] = ...")
+ poetry/installation/installer.py:62: error: Need type annotation for "_whitelist" (hint: "_whitelist: List[<type>] = ...")
- poetry/installation/installer.py:64: error: Need type annotation for '_extras' (hint: "_extras: List[<type>] = ...")
+ poetry/installation/installer.py:64: error: Need type annotation for "_extras" (hint: "_extras: List[<type>] = ...")
- poetry/console/commands/command.py:12: error: Need type annotation for 'loggers' (hint: "loggers: List[<type>] = ...")
+ poetry/console/commands/command.py:12: error: Need type annotation for "loggers" (hint: "loggers: List[<type>] = ...")

JelleZijlstra
JelleZijlstra reviewed Feb 11, 2021
View reviewed changes
docs/source/type_inference_and_annotations.rst
@@ -162,7 +162,7 @@ in the following statement:
def foo(arg: List[int]) -> None:
print('Items:', ', '.join(arg))

a = [] # Error: Need type annotation for 'a'
a = [] # Error: Need type annotation for "a"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job also updating the documentation

@JelleZijlstra JelleZijlstra merged commit 96cae4b into python:master Feb 11, 2021
@PrasanthChettri PrasanthChettri mentioned this pull request Feb 13, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freundTech freundTech freundTech requested changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrasanthChettri @JelleZijlstra @freundTech