Skip to content

Fix #7445 Use double quotes in error messages #10050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix #7445 Use double quotes in error messages #10050

wants to merge 3 commits into from

Conversation

PrasanthChettri
Copy link
Contributor

@PrasanthChettri PrasanthChettri commented Feb 8, 2021

Description

Fixes #7445
Replaces all the instances where single quotes are used in messages with double quotes around the mpypy/messages.py

Test Plan

Only some minor changes in one file, have not done tests, pytest seems to freeze when running pytest -q mypy(not a hardware constraint I can assure), would be helpful if anybody could help me with this

@PrasanthChettri
Copy link
Contributor Author

PrasanthChettri commented Feb 8, 2021

Im getting an Invalid Ouput Assertion error during testing

Detail

Alignment of first line difference:
  E: ...note: Revealed type is 'Any'
  A: ...note: Revealed type is "Any"

From what I gather this is the intended output we want i.e. error messages with double quotes but the tests given below are failing because of it. If anybody would give a feedback it will be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use double quotes in error messages for more consistent colors
1 participant